Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate clickable links to track data in about track dialog #2999

Merged
merged 2 commits into from
Jun 3, 2022

Conversation

cmdcolin
Copy link
Collaborator

@cmdcolin cmdcolin commented Jun 3, 2022

Automatically generates clickable links to files in about track panels or anywhere else where contents look like links in the BaseFeatureDetails attribute panel

Also creates a custom element for UriLocation objects, and resolves relative paths relative to the baseUri, so that files that aren't absolute URLs can get included. This makes it easier for the user to easily download the data because resolving such a file path manually is not straightforward without this

Screenshot from 2022-06-03 09-25-56

Screenshot from 2022-06-03 09-28-37

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Jun 3, 2022
@cmdcolin cmdcolin added enhancement New feature or request and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Jun 3, 2022
@cmdcolin cmdcolin changed the title Generate clickable links to track data in about track dialog paths Generate clickable links to track data in about track dialog Jun 3, 2022
@codecov
Copy link

codecov bot commented Jun 3, 2022

Codecov Report

Merging #2999 (726d912) into main (d11b34b) will increase coverage by 0.00%.
The diff coverage is 70.96%.

@@           Coverage Diff           @@
##             main    #2999   +/-   ##
=======================================
  Coverage   60.78%   60.79%           
=======================================
  Files         584      584           
  Lines       26571    26585   +14     
  Branches     6430     6439    +9     
=======================================
+ Hits        16151    16162   +11     
- Misses      10113    10116    +3     
  Partials      307      307           
Impacted Files Coverage Δ
...kages/core/BaseFeatureWidget/BaseFeatureDetail.tsx 73.93% <70.96%> (-2.22%) ⬇️
packages/core/util/analytics.ts 89.79% <0.00%> (-2.05%) ⬇️
.../linear-genome-view/src/LinearGenomeView/index.tsx 84.93% <0.00%> (-0.35%) ⬇️
packages/core/util/layouts/GranularRectLayout.ts 87.28% <0.00%> (+0.42%) ⬆️
...FeatureRenderer/components/ProcessedTranscript.tsx 88.73% <0.00%> (+1.40%) ⬆️
...gins/svg/src/SvgFeatureRenderer/components/util.ts 95.91% <0.00%> (+4.08%) ⬆️
...src/SvgFeatureRenderer/components/FeatureLabel.tsx 86.20% <0.00%> (+6.89%) ⬆️
...svg/src/SvgFeatureRenderer/components/Segments.tsx 92.85% <0.00%> (+7.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d11b34b...726d912. Read the comment docs.

@cmdcolin cmdcolin merged commit c6a2f84 into main Jun 3, 2022
@cmdcolin cmdcolin deleted the generate_links_details branch June 3, 2022 18:43
@rbuels
Copy link
Contributor

rbuels commented Jun 6, 2022 via email

@cmdcolin
Copy link
Collaborator Author

cmdcolin commented Jun 6, 2022

added in 1ea0ea0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants