-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate clickable links to track data in about track dialog #2999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs label triage
Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal)
label
Jun 3, 2022
cmdcolin
added
enhancement
New feature or request
and removed
needs label triage
Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal)
labels
Jun 3, 2022
cmdcolin
changed the title
Generate clickable links to track data in about track dialog paths
Generate clickable links to track data in about track dialog
Jun 3, 2022
Codecov Report
@@ Coverage Diff @@
## main #2999 +/- ##
=======================================
Coverage 60.78% 60.79%
=======================================
Files 584 584
Lines 26571 26585 +14
Branches 6430 6439 +9
=======================================
+ Hits 16151 16162 +11
- Misses 10113 10116 +3
Partials 307 307
Continue to review full report at Codecov.
|
There is already an isUriLocation in core, could you DRY that up?
…On Fri, Jun 3, 2022 at 8:30 AM Colin Diesh ***@***.***> wrote:
Automatically generates clickable links to files in about track panels or
anywhere else where contents look like links in the BaseFeatureDetails
attribute panel
Also creates a custom element for UriLocation objects, and resolves
relative paths relative to the baseUri, so that files that aren't absolute
URLs can get included. It is otherwise left to the user to manually resolve
such a path themselves relative to the baseUri which can be complicated
sometimes
[image: Screenshot from 2022-06-03 09-25-56]
<https://user-images.githubusercontent.com/6511937/171884686-d5cd2441-6a88-485d-9c7e-5c7cb8d17084.png>
[image: Screenshot from 2022-06-03 09-28-37]
<https://user-images.githubusercontent.com/6511937/171884867-041fe598-8e1d-4b2e-905e-3517234889da.png>
------------------------------
You can view, comment on, or merge this pull request online at:
#2999
Commit Summary
- b0fa576
<b0fa576>
Bump deps
- 726d912
<726d912>
Automatically generate links in about dialogs and entries that look like
links
File Changes
(2 files <https://github.com/GMOD/jbrowse-components/pull/2999/files>)
- *M* packages/core/BaseFeatureWidget/BaseFeatureDetail.tsx
<https://github.com/GMOD/jbrowse-components/pull/2999/files#diff-21b09c647dc31d38e34ebaf534224fbfbf2ac802a06f8383b26e19bce59175b8>
(147)
- *M* yarn.lock
<https://github.com/GMOD/jbrowse-components/pull/2999/files#diff-51e4f558fae534656963876761c95b83b6ef5da5103c4adef6768219ed76c2de>
(1542)
Patch Links:
- https://github.com/GMOD/jbrowse-components/pull/2999.patch
- https://github.com/GMOD/jbrowse-components/pull/2999.diff
—
Reply to this email directly, view it on GitHub
<#2999>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAASAFKGCBUHTGZL3YRWB43VNIQJNANCNFSM5XZLQGIA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
added in 1ea0ea0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatically generates clickable links to files in about track panels or anywhere else where contents look like links in the BaseFeatureDetails attribute panel
Also creates a custom element for UriLocation objects, and resolves relative paths relative to the baseUri, so that files that aren't absolute URLs can get included. This makes it easier for the user to easily download the data because resolving such a file path manually is not straightforward without this