Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jsdom to jbrowse-img to fix --noRasterize option #3009

Merged
merged 4 commits into from
Jun 7, 2022
Merged

Conversation

cmdcolin
Copy link
Collaborator

@cmdcolin cmdcolin commented Jun 6, 2022

Fixes #2997

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Jun 6, 2022
@cmdcolin cmdcolin added bug Something isn't working and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Jun 6, 2022
@cmdcolin
Copy link
Collaborator Author

cmdcolin commented Jun 6, 2022

now has a test that exercises the --noRasterize code path, running jest with --env node to accurately show how it would run on the CLI

@codecov
Copy link

codecov bot commented Jun 6, 2022

Codecov Report

Merging #3009 (5eda5e6) into main (a6a44a9) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #3009      +/-   ##
==========================================
- Coverage   60.79%   60.75%   -0.04%     
==========================================
  Files         584      584              
  Lines       26588    26600      +12     
  Branches     6441     6441              
==========================================
- Hits        16163    16161       -2     
- Misses      10119    10132      +13     
- Partials      306      307       +1     
Impacted Files Coverage Δ
products/jbrowse-img/src/index.js 0.00% <0.00%> (ø)
products/jbrowse-img/src/index.testmod.js 0.00% <0.00%> (ø)
...quenceRenderer/components/DivSequenceRendering.tsx 92.55% <0.00%> (-2.13%) ⬇️
products/jbrowse-web/src/util.ts 27.27% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6a44a9...5eda5e6. Read the comment docs.

@cmdcolin cmdcolin merged commit 8df7c74 into main Jun 7, 2022
@cmdcolin cmdcolin deleted the jsdom_jbimg branch June 7, 2022 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix --noRasterize option in jbrowse-img
1 participant