Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mouseover display of read name to alignments track #3021

Merged
merged 2 commits into from
Jun 9, 2022

Conversation

cmdcolin
Copy link
Collaborator

@cmdcolin cmdcolin commented Jun 8, 2022

Fixes #2996

Customizes the onMouseOver renderProp for the pileup display model to fetch the moused over feature from the remote (similar to a click) and then runs the mouseover callback on it

This could be considered possibly a slow step as it may run many rpc calls quickly while doing this, but in testing it out, it seemed quite fast

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Jun 8, 2022
@cmdcolin cmdcolin added bug Something isn't working and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Jun 8, 2022
@cmdcolin
Copy link
Collaborator Author

cmdcolin commented Jun 8, 2022

potentially we could add additional mouseover information about the position of the read you are hovering over, but may be an add-on

@codecov
Copy link

codecov bot commented Jun 8, 2022

Codecov Report

Merging #3021 (5b15898) into main (ba0975e) will increase coverage by 0.04%.
The diff coverage is 91.37%.

@@            Coverage Diff             @@
##             main    #3021      +/-   ##
==========================================
+ Coverage   61.20%   61.25%   +0.04%     
==========================================
  Files         586      587       +1     
  Lines       26663    26683      +20     
  Branches     6466     6470       +4     
==========================================
+ Hits        16319    16344      +25     
+ Misses      10037    10031       -6     
- Partials      307      308       +1     
Impacted Files Coverage Δ
...lugins/alignments/src/LinearPileupDisplay/model.ts 66.52% <85.18%> (+1.54%) ⬆️
...-view/src/BaseLinearDisplay/components/Tooltip.tsx 96.29% <96.29%> (ø)
...BaseLinearDisplay/components/BaseLinearDisplay.tsx 83.72% <100.00%> (+6.90%) ⬆️
...aseLinearDisplay/models/BaseLinearDisplayModel.tsx 85.91% <100.00%> (ø)
...quenceRenderer/components/DivSequenceRendering.tsx 92.55% <0.00%> (-2.13%) ⬇️
products/jbrowse-web/src/util.ts 27.27% <0.00%> (ø)
.../linear-genome-view/src/LinearGenomeView/index.tsx 85.23% <0.00%> (+0.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba0975e...5b15898. Read the comment docs.

@cmdcolin
Copy link
Collaborator Author

cmdcolin commented Jun 9, 2022

I think this should be good to go. kind of does a fun little autorun that listens to featureIdUnderMouse, and fetches the feature data using that, so it only runs if a new feature is moused over, and it also only updates the featureUnderMouse if the feature it gets back from the async CoreGetFeature call equals the id of featureIdUnderMouse (so no stale update from the async call)

@cmdcolin cmdcolin merged commit afe37c1 into main Jun 9, 2022
@cmdcolin cmdcolin deleted the pileup_mouseover branch June 9, 2022 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix mouseovers on pileup track
1 participant