Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dotplot session spec #3025

Merged
merged 2 commits into from
Jun 13, 2022
Merged

Add dotplot session spec #3025

merged 2 commits into from
Jun 13, 2022

Conversation

cmdcolin
Copy link
Collaborator

Example

http://localhost:3000/?config=test_data/volvox/config_main_thread.json&session=spec-{"views":[{"type":"DotplotView","views":[{"assembly":"volvox"},{"assembly":"volvox"}],"tracks":["volvox_fake_synteny"]}]}

Expanded

{
  views: [
    {
      type: "DotplotView",
      views: [{ assembly: "volvox" }, { assembly: "volvox" }],
      tracks: ["volvox_fake_synteny"],
    },
  ],
};

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Jun 10, 2022
@codecov
Copy link

codecov bot commented Jun 10, 2022

Codecov Report

Merging #3025 (2e52c68) into main (1d8e7e8) will increase coverage by 0.03%.
The diff coverage is 70.37%.

@@            Coverage Diff             @@
##             main    #3025      +/-   ##
==========================================
+ Coverage   61.51%   61.54%   +0.03%     
==========================================
  Files         588      589       +1     
  Lines       26804    26828      +24     
  Branches     6502     6506       +4     
==========================================
+ Hits        16489    16512      +23     
- Misses      10007    10008       +1     
  Partials      308      308              
Impacted Files Coverage Δ
plugins/dotplot-view/src/DotplotView/model.ts 58.29% <ø> (ø)
plugins/dotplot-view/src/LaunchDotplotView.ts 65.21% <65.21%> (ø)
plugins/dotplot-view/src/index.ts 100.00% <100.00%> (ø)
...ar-comparative-view/src/LaunchLinearSyntenyView.ts 72.72% <100.00%> (ø)
...rative-view/src/ServerSideRenderedBlockContent.tsx 64.00% <0.00%> (-4.00%) ⬇️
packages/core/util/index.ts 86.31% <0.00%> (+0.23%) ⬆️
...ns/dotplot-view/src/DotplotView/components/util.ts 86.36% <0.00%> (+3.03%) ⬆️
...otplot-view/src/DotplotRenderer/DotplotRenderer.ts 79.52% <0.00%> (+3.93%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d8e7e8...2e52c68. Read the comment docs.

@cmdcolin
Copy link
Collaborator Author

there is not yet a good navToLocString type thing on dotplot view compared with lgv, so it just loads a whole genome overview of both assemblies

@cmdcolin cmdcolin added enhancement New feature or request and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Jun 11, 2022
@cmdcolin cmdcolin merged commit 18a385d into main Jun 13, 2022
@cmdcolin cmdcolin deleted the dotplot_spec branch June 13, 2022 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant