Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix export SVG crash on some BigWig tracks #3057

Merged
merged 1 commit into from
Jun 24, 2022
Merged

Fix export SVG crash on some BigWig tracks #3057

merged 1 commit into from
Jun 24, 2022

Conversation

cmdcolin
Copy link
Collaborator

Fixes #3046

Need to make sure to stringify the result. The HTML5 canvas API presumably automatically stringifies the fillStyle object, but canvas2svg needs to do this manually.

It is perhaps a bit surprising that typescript does not catch the Color object as not being a string in our custom fillRect helper function, but this PR should help avoid crash

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Jun 24, 2022
@cmdcolin cmdcolin added bug Something isn't working and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Jun 24, 2022
@codecov
Copy link

codecov bot commented Jun 24, 2022

Codecov Report

Merging #3057 (96c1407) into main (1fbc3c1) will decrease coverage by 0.00%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##             main    #3057      +/-   ##
==========================================
- Coverage   61.29%   61.28%   -0.01%     
==========================================
  Files         591      591              
  Lines       26981    26981              
  Branches     6527     6527              
==========================================
- Hits        16537    16536       -1     
  Misses      10146    10146              
- Partials      298      299       +1     
Impacted Files Coverage Δ
...lugins/wiggle/src/XYPlotRenderer/XYPlotRenderer.ts 66.29% <33.33%> (ø)
...quenceRenderer/components/DivSequenceRendering.tsx 92.55% <0.00%> (-2.13%) ⬇️
products/jbrowse-web/src/util.ts 27.27% <0.00%> (ø)
plugins/breakpoint-split-view/src/model.ts 78.26% <0.00%> (+1.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fbc3c1...96c1407. Read the comment docs.

@cmdcolin cmdcolin merged commit 6c7c106 into main Jun 24, 2022
@cmdcolin cmdcolin deleted the fix_svg_crash branch June 24, 2022 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SVG export fails when rasterization is off
1 participant