Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix feature labels being choppy by downgrading react 18 to react 17 #3059

Merged
merged 1 commit into from Jun 27, 2022

Conversation

cmdcolin
Copy link
Collaborator

I noticed on react 18 that the "floating feature labels" (feature label stays shown on left side of screen while scrolling feature) would look "choppy" when side scrolling the app.

It appears to be due to using react 18. This could be due to any number of reasons but react does say that it "interupts" rendering with react 18. We can still "support" react 18 but the floating feature labels look less smooth in it, so our "apps" might want to stay on react 17. I upgraded to react 18 in the mui5 branch, but it appears it will be better to stay on react 17 for now.

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Jun 27, 2022
@cmdcolin cmdcolin removed the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Jun 27, 2022
@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Jun 27, 2022
@cmdcolin cmdcolin removed the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Jun 27, 2022
@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Jun 27, 2022
@cmdcolin cmdcolin removed the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Jun 27, 2022
@cmdcolin cmdcolin merged commit 289651c into main Jun 27, 2022
@cmdcolin cmdcolin deleted the fix_floating_labels branch June 27, 2022 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant