Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow changing between xyplot,line,density for linear wiggle tracks and other small fixes #3065

Merged
merged 4 commits into from
Jun 28, 2022

Conversation

cmdcolin
Copy link
Collaborator

Fixes #3051

  • Allows toggling renderer type from the linearwiggledisplay->trackMenuItems if defaultRendering has a configSlot value (helps with e.g. snpcoverage which uses the linearwiggledisplay model but does not have multiple renderers)
  • Moves some of the renderer-specific config slots to the individual renderers
  • Fixes ability to change filled, displayCrossHatches from the config editor

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Jun 28, 2022
@codecov
Copy link

codecov bot commented Jun 28, 2022

Codecov Report

Merging #3065 (3c58d72) into main (7935404) will increase coverage by 0.03%.
The diff coverage is 67.64%.

@@            Coverage Diff             @@
##             main    #3065      +/-   ##
==========================================
+ Coverage   61.51%   61.55%   +0.03%     
==========================================
  Files         591      591              
  Lines       26979    26977       -2     
  Branches     6527     6529       +2     
==========================================
+ Hits        16597    16606       +9     
+ Misses      10085    10074      -11     
  Partials      297      297              
Impacted Files Coverage Δ
plugins/wiggle/src/LinePlotRenderer/index.js 100.00% <ø> (ø)
plugins/wiggle/src/XYPlotRenderer/index.ts 100.00% <ø> (ø)
...ns/wiggle/src/LinearWiggleDisplay/models/model.tsx 72.58% <67.64%> (+3.38%) ⬆️
plugins/hic/src/HicRenderer/HicRenderer.tsx 100.00% <0.00%> (+4.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7935404...3c58d72. Read the comment docs.

@cmdcolin cmdcolin added enhancement New feature or request and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Jun 28, 2022
@cmdcolin cmdcolin merged commit 9f87f01 into main Jun 28, 2022
@cmdcolin cmdcolin deleted the wiggle_track_fixes branch June 28, 2022 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BigWig renderer and display issues
1 participant