Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescriptify some integration tests #3067

Merged
merged 7 commits into from
Jun 29, 2022
Merged

Conversation

cmdcolin
Copy link
Collaborator

Adds a helper function "createView" that renders the LGV, and gives back a handle to the view with correct typescript types

Also fixes a flaky test on main: it complains the test was torn down but then an async import was made
https://github.com/GMOD/jbrowse-components/runs/7102110874?check_suite_focus=true#step:5:81 which is fixed by not loading an alignments track at all in this test (just using trackRenderingContainer for click and drag)

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Jun 29, 2022
@codecov
Copy link

codecov bot commented Jun 29, 2022

Codecov Report

Merging #3067 (c15c115) into main (9f87f01) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #3067      +/-   ##
==========================================
- Coverage   61.57%   61.56%   -0.02%     
==========================================
  Files         591      591              
  Lines       26977    26986       +9     
  Branches     6529     6529              
==========================================
+ Hits        16611    16613       +2     
- Misses      10069    10076       +7     
  Partials      297      297              
Impacted Files Coverage Δ
...rc/LinearGenomeView/components/TracksContainer.tsx 63.75% <ø> (ø)
products/jbrowse-web/src/tests/util.tsx 93.84% <100.00%> (+0.98%) ⬆️
...svg/src/SvgFeatureRenderer/components/Segments.tsx 85.71% <0.00%> (-7.15%) ⬇️
...src/SvgFeatureRenderer/components/FeatureLabel.tsx 77.41% <0.00%> (-6.46%) ⬇️
...gins/svg/src/SvgFeatureRenderer/components/util.ts 91.83% <0.00%> (-4.09%) ⬇️
...FeatureRenderer/components/ProcessedTranscript.tsx 87.32% <0.00%> (-1.41%) ⬇️
packages/core/util/layouts/GranularRectLayout.ts 86.86% <0.00%> (-0.43%) ⬇️
products/jbrowse-web/src/util.ts 27.27% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f87f01...c15c115. Read the comment docs.

@cmdcolin cmdcolin added internal and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Jun 29, 2022
@cmdcolin cmdcolin merged commit 87269a6 into main Jun 29, 2022
@cmdcolin cmdcolin deleted the typescript_integration_tests branch June 29, 2022 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant