Support the "name" field on multi-wiggle adapter subadapters instead of source #3157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs label triage
cmdcolin
added
bug
Codecov Report
@@ Coverage Diff @@
## main #3157 +/- ##
==========================================
- Coverage 58.80% 58.80% -0.01%
==========================================
Files 648 648
Lines 29043 29044 +1
Branches 7066 7067 +1
==========================================
Hits 17079 17079
- Misses 11585 11586 +1
Partials 379 379
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
cmdcolin
force-pushed
the
subadapters_name_field
branch
from
90ebefc
to
f5d5106
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3122
"name" may be a fairly intuitive key to specify on the subadapter, so if "name" is specified without a "source" field, it is used. If both "source" and "name" are specified, "source" is given priority