-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix drawing inverted CIGAR segments on dotplot #3170
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs label triage
Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal)
label
Sep 4, 2022
Codecov Report
@@ Coverage Diff @@
## main #3170 +/- ##
==========================================
+ Coverage 59.45% 59.50% +0.04%
==========================================
Files 671 671
Lines 28628 28633 +5
Branches 6926 6927 +1
==========================================
+ Hits 17022 17039 +17
+ Misses 11284 11272 -12
Partials 322 322
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
cmdcolin
added
bug
Something isn't working
and removed
needs label triage
Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal)
labels
Sep 6, 2022
cmdcolin
force-pushed
the
fix_inverted_cigar_dotplot
branch
from
September 6, 2022 21:29
87d1761
to
87a1026
Compare
cmdcolin
force-pushed
the
fix_inverted_cigar_dotplot
branch
from
September 6, 2022 22:35
87a1026
to
f3c82e0
Compare
cmdcolin
force-pushed
the
fix_inverted_cigar_dotplot
branch
from
September 7, 2022 18:52
b98f59a
to
77b4679
Compare
added a canvas-snapshot integration test for drawing an inverted alignment now also went through and typescript-ified a bunch of the integration tests |
cmdcolin
force-pushed
the
fix_inverted_cigar_dotplot
branch
from
September 7, 2022 19:07
77b4679
to
4ced53f
Compare
cmdcolin
added a commit
that referenced
this pull request
Sep 14, 2022
* Fix drawing inverted segments on dotplot renderer * Accomodate undefined MatePosition * Typescriptify test * More typescripting * Gzip + CIGAR gzip * More typescripting * More typescripting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example link
http://jbrowse.org/code/jb2/fix_inverted_cigar_dotplot/?config=test_data%2Fconfig_dotplot.json&session=share-6ilxWDe7Ts&password=DQxxV
Note the top view actually has query and target backwards (and produces warnings), and the bottom one has it right (and has no warnings)