Fix "dead state tree node" error by creating snapshots of parent region for block calculations #3182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs label triage
cmdcolin
removed
the
needs label triage
|
an alternative fix could consider removing parentRegion |
cmdcolin
changed the title
cmdcolin
changed the title
Codecov Report
@@ Coverage Diff @@
## main #3182 +/- ##
==========================================
+ Coverage 59.49% 59.52% +0.02%
==========================================
Files 671 671
Lines 28644 28646 +2
Branches 6934 6936 +2
==========================================
+ Hits 17043 17052 +9
+ Misses 11279 11272 -7
Partials 322 322
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
maybe can merge for now |
cmdcolin
added a commit
that referenced
this pull request
Sep 14, 2022
…on for block calculations (#3182) Ensure parentRegion gets a snapshot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found a relatively reproducible procedure to create the dead state tree node error, and a probable fix for this particular case
A good portion of the time, this produces the error in #3181
I found that the "parentRegion" attribute in the static/dynamic blocks were not snapshots and were instead proxies for the state tree node, creating this error
Note that this change could mildly slow down the block calculations. Note also that parentRegion is not even used anywhere in our codebase, but have some hypothetical use cases
Fixes #3181