Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'Open saved session' button to start screen on desktop #3188

Merged
merged 2 commits into from
Sep 15, 2022

Conversation

cmdcolin
Copy link
Collaborator

fixes #3185
Screenshot from 2022-09-15 11-31-53

Also uses a MUI grid to vertically center the button, checkbox, etc. (which is a technique I hadn't known before, could apply to other places in app potentially where that is relevant)

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Sep 15, 2022
@codecov
Copy link

codecov bot commented Sep 15, 2022

Codecov Report

Merging #3188 (3c29d5c) into main (8d4fa57) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

❗ Current head 3c29d5c differs from pull request most recent head 0120028. Consider uploading reports for the commit 0120028 to get more accurate results

@@            Coverage Diff             @@
##             main    #3188      +/-   ##
==========================================
- Coverage   59.50%   59.48%   -0.02%     
==========================================
  Files         671      671              
  Lines       28729    28738       +9     
  Branches     6966     6968       +2     
==========================================
  Hits        17094    17094              
- Misses      11313    11322       +9     
  Partials      322      322              
Impacted Files Coverage Δ
...se-desktop/src/StartScreen/RecentSessionsPanel.tsx 0.00% <0.00%> (ø)
products/jbrowse-web/src/util.ts 48.33% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cmdcolin cmdcolin added enhancement New feature or request and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Sep 15, 2022
@cmdcolin cmdcolin merged commit 476a937 into main Sep 15, 2022
@cmdcolin cmdcolin deleted the open_saved_desktop branch September 15, 2022 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Open file option from landing/start screen on JBrowse desktop
2 participants