Improve error reporting on jbrowse-web start screen when user attempts to open a broken recent session #3198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
carolinebridge
commented
Sep 19, 2022
carolinebridge
commented
- removes deprecated prop ("raised") on listItem to fix a console error
- sets a message for the user instead of throwing an error on the front end that was causing a crash if the user attempted to open a "Recent session" that cannot be loaded
…ead of throwing an error that crashes the application if the user clicks a session that cannot be loaded
Codecov Report
@@ Coverage Diff @@
## main #3198 +/- ##
==========================================
+ Coverage 59.48% 59.54% +0.06%
==========================================
Files 671 670 -1
Lines 28734 28717 -17
Branches 6968 6968
==========================================
+ Hits 17092 17100 +8
+ Misses 11320 11296 -24
+ Partials 322 321 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
looks good. might also be worth using the @jbrowse/core/ui/ErrorMessage component and giving user actual error message in this case |
|
could also be good to typescriptify the RecentSessionCards to tsx |
cmdcolin
reviewed
Sep 20, 2022
cmdcolin
reviewed
Sep 20, 2022
cmdcolin
changed the title
cmdcolin
changed the title
cmdcolin
pushed a commit
that referenced
this pull request
Sep 30, 2022
… to open a broken recent session (#3198) * removes deprecated prop on listitem, sets a message for the user instead of throwing an error that crashes the application if the user clicks a session that cannot be loaded * tsx update and change start screen to use internal error message * lint * displays full error message instead of custom message
cmdcolin
changed the title
cmdcolin
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.