Fix authentication configuration on jbrowse-desktop #3204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs label triage
cmdcolin
added
bug
Codecov Report
@@ Coverage Diff @@
## main #3204 +/- ##
=======================================
Coverage 59.48% 59.48%
=======================================
Files 671 671
Lines 28734 28734
Branches 6968 6968
=======================================
Hits 17092 17092
Misses 11320 11320
Partials 322 322
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
the jbrowse-web version is actually correct so this is jbrowse-desktop specific and this issue actually traces back to me making bad refactors |
cmdcolin
changed the title
cmdcolin
added a commit
that referenced
this pull request
Sep 30, 2022
Fix initializing internet accounts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This passes a "configuration" object instead of a "config" object. I am actually a bit confused on how the internet account code worked without this fix, but this PR would fix #3201