Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error reporting on SV inspector/spreadsheet view on import form #3220

Merged
merged 9 commits into from
Sep 26, 2022

Conversation

cmdcolin
Copy link
Collaborator

Possibly fix for #3219

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Sep 26, 2022
@cmdcolin cmdcolin changed the title Better error display on sv inspector/spreadsheet view Better error display on SV inspector/spreadsheet view on import form Sep 26, 2022
@cmdcolin cmdcolin added enhancement New feature or request and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Sep 26, 2022
@carolinebridge
Copy link
Contributor

Not sure if this is a me-thing and my display or something but could you increase the default height of the view for both of these such that the open button is visible from the get-go? If I am scrolled down to click the Open button for the file, I actually can't see the error message because it renders at the top of the view and I'm scrolled to the bottom.

Not sure if this communicates what I mean, but here's some ss's:
Screen Shot 2022-09-26 at 3 12 08 PM
^ default when the view opens the Open button is obscured below the scroll
Screen Shot 2022-09-26 at 3 12 16 PM
^ scrolling down its there but the top gets cut off, the error message is actually displayed in this ss but obscured by the scroll

@codecov
Copy link

codecov bot commented Sep 26, 2022

Codecov Report

Merging #3220 (446e127) into main (46d72f9) will decrease coverage by 0.03%.
The diff coverage is 34.57%.

❗ Current head 446e127 differs from pull request most recent head 57c2a35. Consider uploading reports for the commit 57c2a35 to get more accurate results

@@            Coverage Diff             @@
##             main    #3220      +/-   ##
==========================================
- Coverage   59.40%   59.37%   -0.04%     
==========================================
  Files         673      671       -2     
  Lines       28797    28759      -38     
  Branches     6985     6978       -7     
==========================================
- Hits        17108    17076      -32     
- Misses      11368    11378      +10     
+ Partials      321      305      -16     
Impacted Files Coverage Δ
...iew/src/SpreadsheetView/components/Spreadsheet.tsx 66.66% <ø> (ø)
...c/SpreadsheetView/models/ColumnDataTypes/LocRef.ts 50.00% <0.00%> (ø)
...SpreadsheetView/models/ColumnDataTypes/LocStart.ts 50.00% <0.00%> (ø)
...dels/ColumnDataTypes/MakeSpreadsheetColumnType.tsx 72.72% <ø> (ø)
.../SpreadsheetView/models/ColumnDataTypes/Number.tsx 10.60% <8.69%> (ø)
...readsheetView/models/ColumnDataTypes/LocString.tsx 10.90% <9.37%> (ø)
...rc/SpreadsheetView/models/ColumnDataTypes/Text.tsx 14.81% <13.33%> (ø)
...ctor/src/SvInspectorView/models/SvInspectorView.ts 70.31% <75.00%> (-0.15%) ⬇️
...src/SpreadsheetView/components/SpreadsheetView.tsx 74.60% <86.95%> (-0.84%) ⬇️
...src/SvInspectorView/components/SvInspectorView.tsx 73.91% <87.50%> (ø)
... and 9 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cmdcolin
Copy link
Collaborator Author

I have same thing on my computer with scrolling down to open button, etc. I'll see if I can adjust

@cmdcolin cmdcolin merged commit 56886d4 into main Sep 26, 2022
@cmdcolin cmdcolin deleted the sv_inspector_error_checking branch September 26, 2022 21:41
cmdcolin added a commit that referenced this pull request Sep 30, 2022
…3220)

* Better error display on sv inspector/spreadsheet view

* Some typescripting

* More typescripting

* Slightly better typescripting

* More typescripting

* More space for importform yet still

* More typescripting

* More typescripting

* More typescripting
@cmdcolin cmdcolin changed the title Better error display on SV inspector/spreadsheet view on import form Improve error reporting on SV inspector/spreadsheet view on import form Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants