Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow adding session tracks to embedded react component along with disableAddTracks option if unwanted #3223

Merged
merged 3 commits into from
Sep 29, 2022

Conversation

cmdcolin
Copy link
Collaborator

I made it so the embedded react LGV component has the ability to add session tracks, along with a flag "disableAddTracks" to optionally disable it. "disableAddTracks" is off by default.

I also made it so that extension points can be evaluated with a second "props" argument. This allows passing the session model to the extension point, and it does not have to participate in the "accumulator" pipeline (before this, the only way to pass information to extension points is via the accumulator param which is subsequently returned by each extension point). This allows e.g. checking that the TrackSelect-multiTrackMenuItems extension point should add a multi-wiggle add track widget by checking the new extra session prop

Fixes #3205 (The sequence search track uses session tracks for example, and assumed it existed always, but this is not always true)

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Sep 27, 2022
@cmdcolin cmdcolin added enhancement New feature or request and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Sep 27, 2022
@codecov
Copy link

codecov bot commented Sep 27, 2022

Codecov Report

Merging #3223 (36d9e36) into main (85c73a5) will increase coverage by 0.00%.
The diff coverage is 31.37%.

@@           Coverage Diff           @@
##             main    #3223   +/-   ##
=======================================
  Coverage   59.42%   59.42%           
=======================================
  Files         672      672           
  Lines       28752    28772   +20     
  Branches     6977     6984    +7     
=======================================
+ Hits        17086    17098   +12     
- Misses      11387    11393    +6     
- Partials      279      281    +2     
Impacted Files Coverage Δ
...rarchicalTrackSelectorWidget/components/Header.tsx 42.85% <ø> (ø)
plugins/wiggle/src/index.ts 92.50% <ø> (ø)
...-genome-view/src/createModel/createSessionModel.ts 18.23% <15.38%> (+0.23%) ⬆️
...ins/wiggle/src/CreateMultiWiggleExtension/index.ts 25.92% <20.00%> (+7.74%) ⬆️
.../linear-genome-view/src/LinearGenomeView/index.tsx 83.04% <33.33%> (-0.26%) ⬇️
packages/core/PluginManager.ts 92.40% <100.00%> (ø)
packages/core/util/types/index.ts 67.46% <100.00%> (+0.39%) ⬆️
...-linear-genome-view/src/createModel/createModel.ts 62.50% <100.00%> (ø)
...se-react-linear-genome-view/src/createViewState.ts 50.00% <100.00%> (+2.00%) ⬆️
...ments/src/SNPCoverageAdapter/SNPCoverageAdapter.ts 58.00% <0.00%> (+0.66%) ⬆️
... and 2 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cmdcolin cmdcolin merged commit c6facdc into main Sep 29, 2022
@cmdcolin cmdcolin deleted the session_track_embedded branch September 29, 2022 14:41
cmdcolin added a commit that referenced this pull request Sep 30, 2022
…sableAddTracks option if unwanted (#3223)

* Add session tracks to embedded

* Enable adding tracks to embedded, with a flag to disable it at view creation

* Allow passing props to extension point
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sequence search track doesn't work on embedded
1 participant