Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user to select local assembly to add tracks to for trackhub registry #3229

Merged
merged 1 commit into from
Sep 29, 2022

Conversation

cmdcolin
Copy link
Collaborator

This allows a user to select a local assembly name to add their tracks from the trackhub registry to

It might be the case that the name of the user's local assembly does not match the remote name provided by the trackhub, so this allows the user to select the local assembly to add the trackhub tracks to.

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Sep 29, 2022
@cmdcolin cmdcolin added enhancement New feature or request and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Sep 29, 2022
@cmdcolin
Copy link
Collaborator Author

Allowing us to load assemblies from the trackhub itself may also be a good add on

@codecov
Copy link

codecov bot commented Sep 29, 2022

Codecov Report

Merging #3229 (c0e7fe0) into main (5ef8f93) will increase coverage by 0.01%.
The diff coverage is 16.66%.

❗ Current head c0e7fe0 differs from pull request most recent head 06995fa. Consider uploading reports for the commit 06995fa to get more accurate results

@@            Coverage Diff             @@
##             main    #3229      +/-   ##
==========================================
+ Coverage   59.40%   59.42%   +0.01%     
==========================================
  Files         672      672              
  Lines       28775    28785      +10     
  Branches     7001     6998       -3     
==========================================
+ Hits        17095    17105      +10     
+ Misses      11405    11400       -5     
- Partials      275      280       +5     
Impacted Files Coverage Δ
...onnectionWidget/components/AddConnectionWidget.tsx 87.80% <ø> (ø)
...y/src/trackhub-registry/TrackHubRegistrySelect.tsx 0.00% <0.00%> (ø)
...ionEditorWidget/components/ConfigurationEditor.tsx 89.18% <100.00%> (ø)
...onnectionWidget/components/ConfigureConnection.tsx 100.00% <100.00%> (ø)
packages/core/ui/theme.ts 83.33% <0.00%> (-1.29%) ⬇️
products/jbrowse-web/src/util.ts 48.33% <0.00%> (ø)
packages/core/util/types/index.ts 67.46% <0.00%> (ø)
.../linear-genome-view/src/LinearGenomeView/index.tsx 83.17% <0.00%> (ø)
...inearPileupDisplay/components/SetFeatureHeight.tsx 0.00% <0.00%> (ø)
...nearGenomeView/components/SequenceSearchDialog.tsx 0.00% <0.00%> (ø)
... and 10 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cmdcolin cmdcolin force-pushed the select_trackhub_local_assembly branch from c0e7fe0 to 4627317 Compare September 29, 2022 19:20
@cmdcolin cmdcolin force-pushed the select_trackhub_local_assembly branch from 4627317 to 06995fa Compare September 29, 2022 19:36
@cmdcolin cmdcolin merged commit 2a8388b into main Sep 29, 2022
@cmdcolin cmdcolin deleted the select_trackhub_local_assembly branch September 29, 2022 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant