Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for flaky test #3261

Merged
merged 1 commit into from
Oct 10, 2022
Merged

Fix for flaky test #3261

merged 1 commit into from
Oct 10, 2022

Conversation

cmdcolin
Copy link
Collaborator

Possible fix for #3260

This fix creates a small minimal config for testing the wrong assembly error

A possible alternative to this approach would be checking that the LGV is initialized before finishing test, but I think the minimal config would not try to load any refnamealiases and thus would not cause any error

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Oct 10, 2022
@cmdcolin cmdcolin added internal and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Oct 10, 2022
@codecov
Copy link

codecov bot commented Oct 10, 2022

Codecov Report

Merging #3261 (4a32fbd) into main (1b3cd83) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #3261      +/-   ##
==========================================
+ Coverage   59.45%   59.47%   +0.02%     
==========================================
  Files         676      676              
  Lines       28823    28823              
  Branches     7038     7038              
==========================================
+ Hits        17137    17143       +6     
+ Misses      11412    11406       -6     
  Partials      274      274              
Impacted Files Coverage Δ
packages/core/assemblyManager/assembly.ts 90.13% <100.00%> (ø)
...rative-view/src/ServerSideRenderedBlockContent.tsx 64.00% <0.00%> (-4.00%) ⬇️
products/jbrowse-web/src/util.ts 48.33% <0.00%> (ø)
packages/core/util/layouts/GranularRectLayout.ts 87.28% <0.00%> (+0.42%) ⬆️
...FeatureRenderer/components/ProcessedTranscript.tsx 88.73% <0.00%> (+1.40%) ⬆️
...gins/svg/src/SvgFeatureRenderer/components/util.ts 95.91% <0.00%> (+4.08%) ⬆️
...src/SvgFeatureRenderer/components/FeatureLabel.tsx 82.50% <0.00%> (+5.00%) ⬆️
...svg/src/SvgFeatureRenderer/components/Segments.tsx 92.85% <0.00%> (+7.14%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cmdcolin cmdcolin merged commit ac945e1 into main Oct 10, 2022
@cmdcolin cmdcolin deleted the flaky_test_aid branch October 10, 2022 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant