Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create new "Add track workflow" that allows pasting JSON track configs #3277

Merged
merged 1 commit into from
Nov 17, 2022

Conversation

cmdcolin
Copy link
Collaborator

This is a very simple component that let's users paste a config in plain JSON format

This would be an escape hatch for expert users or perhaps users getting instruction. sometimes I imagine it being helpful in a workshop for users to paste a particular thing rather than click and edit the GUI a bunch after adding the basic instance of a track

Screenshot from 2022-10-17 18-08-54

sort of the GUI version of the add-track-json CLI

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Oct 18, 2022
@cmdcolin cmdcolin removed the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Oct 18, 2022
@codecov
Copy link

codecov bot commented Oct 18, 2022

Codecov Report

Merging #3277 (a539610) into main (b903476) will decrease coverage by 0.02%.
The diff coverage is 5.88%.

❗ Current head a539610 differs from pull request most recent head 4c65301. Consider uploading reports for the commit 4c65301 to get more accurate results

@@            Coverage Diff             @@
##             main    #3277      +/-   ##
==========================================
- Coverage   59.19%   59.16%   -0.03%     
==========================================
  Files         749      750       +1     
  Lines       29240    29257      +17     
  Branches     7083     7084       +1     
==========================================
+ Hits        17308    17310       +2     
- Misses      11683    11698      +15     
  Partials      249      249              
Impacted Files Coverage Δ
...t/src/AddTrackWidget/components/AddTrackWidget.tsx 90.90% <ø> (ø)
...lugins/data-management/src/AddTrackWidget/model.ts 83.72% <ø> (ø)
.../AddTrackWidget/components/PasteConfigWorkflow.tsx 5.88% <5.88%> (ø)
products/jbrowse-web/src/util.ts 48.33% <0.00%> (ø)
...rative-view/src/ServerSideRenderedBlockContent.tsx 66.66% <0.00%> (+4.16%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cmdcolin
Copy link
Collaborator Author

now that we have these workflows, moving forward with a multi-track adder may be valuable...paste list of URLs, etc.

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Nov 17, 2022
@cmdcolin cmdcolin added enhancement New feature or request and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Nov 17, 2022
@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Nov 17, 2022
@cmdcolin cmdcolin merged commit 537cc90 into main Nov 17, 2022
@cmdcolin cmdcolin deleted the add_json_track_workflow branch November 17, 2022 22:52
@cmdcolin cmdcolin changed the title Add track workflow that allows pasting JSON config Create new "Add track workflow" that allows pasting JSON track configs Nov 17, 2022
@cmdcolin cmdcolin removed the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant