Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix animated "Loading..." message keyframes #3309

Merged
merged 2 commits into from
Nov 2, 2022
Merged

Fix animated "Loading..." message keyframes #3309

merged 2 commits into from
Nov 2, 2022

Conversation

cmdcolin
Copy link
Collaborator

@cmdcolin cmdcolin commented Nov 2, 2022

Was lost during the mui4->mui5 transition

Fixes #3307

@cmdcolin cmdcolin marked this pull request as ready for review November 2, 2022 15:25
@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Nov 2, 2022
@cmdcolin cmdcolin added bug Something isn't working and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Nov 2, 2022
@codecov
Copy link

codecov bot commented Nov 2, 2022

Codecov Report

Merging #3309 (7bc7ee5) into main (14aa9fa) will increase coverage by 0.00%.
The diff coverage is 78.94%.

❗ Current head 7bc7ee5 differs from pull request most recent head 72c9160. Consider uploading reports for the commit 72c9160 to get more accurate results

@@           Coverage Diff           @@
##             main    #3309   +/-   ##
=======================================
  Coverage   59.44%   59.45%           
=======================================
  Files         735      736    +1     
  Lines       28985    28989    +4     
  Branches     7012     7013    +1     
=======================================
+ Hits        17230    17235    +5     
+ Misses      11509    11508    -1     
  Partials      246      246           
Impacted Files Coverage Δ
.../core/BaseFeatureWidget/SequenceFeatureDetails.tsx 38.93% <0.00%> (ø)
packages/core/ui/App.tsx 76.71% <ø> (ø)
packages/core/ui/DrawerWidget.tsx 80.00% <ø> (ø)
...onnectionWidget/components/ConfigureConnection.tsx 100.00% <ø> (ø)
...comparative-view/src/ServerSideRenderedContent.tsx 0.00% <0.00%> (ø)
...play/components/ServerSideRenderedBlockContent.tsx 100.00% <ø> (ø)
...browse-desktop/src/StartScreen/QuickstartPanel.tsx 0.00% <0.00%> (ø)
products/jbrowse-web/src/Loader.tsx 61.90% <50.00%> (ø)
packages/core/ui/AboutDialog.tsx 75.80% <100.00%> (ø)
packages/core/ui/LoadingEllipses.tsx 100.00% <100.00%> (ø)
... and 7 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cmdcolin cmdcolin merged commit 6cf17fd into main Nov 2, 2022
@cmdcolin cmdcolin deleted the loading_ellip branch November 2, 2022 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Loading" text animated ellipses not working
1 participant