Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ErrorBoundary so that tracks/views that have crashed can be closed more easily #3317

Merged
merged 2 commits into from
Nov 14, 2022

Conversation

cmdcolin
Copy link
Collaborator

@cmdcolin cmdcolin commented Nov 8, 2022

Currently if a track has something that hits the track level error boundary, then the track label is not displayed so the track is more difficult to close (have to use tracklist maybe)

Note: It is a little uncommon to even have this ErrorBoundary show up as there are other error handling mechanisms related to data fetching and whatnot, but this ErrorBoundary can be useful catching unexpected hard crashes in the component code and avoiding the whole session, or in this case, the whole view, from being crashed.

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Nov 8, 2022
@cmdcolin
Copy link
Collaborator Author

cmdcolin commented Nov 8, 2022

some cases where the "tracklabel itself will crash the view" that will not be caught by this but probably not a large concern

@cmdcolin cmdcolin removed the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Nov 8, 2022
@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Nov 8, 2022
@codecov
Copy link

codecov bot commented Nov 8, 2022

Codecov Report

Merging #3317 (ee34e5e) into main (d54632d) will decrease coverage by 0.00%.
The diff coverage is 62.50%.

❗ Current head ee34e5e differs from pull request most recent head f4e3e6e. Consider uploading reports for the commit f4e3e6e to get more accurate results

@@            Coverage Diff             @@
##             main    #3317      +/-   ##
==========================================
- Coverage   59.44%   59.44%   -0.01%     
==========================================
  Files         736      736              
  Lines       28997    28996       -1     
  Branches     7017     7017              
==========================================
- Hits        17238    17236       -2     
- Misses      11513    11514       +1     
  Partials      246      246              
Impacted Files Coverage Δ
packages/core/ui/App.tsx 76.71% <50.00%> (ø)
...src/LinearGenomeView/components/TrackContainer.tsx 88.57% <60.00%> (-2.61%) ⬇️
...c/LinearGenomeView/components/LinearGenomeView.tsx 84.00% <100.00%> (+2.51%) ⬆️
...rative-view/src/ServerSideRenderedBlockContent.tsx 62.50% <0.00%> (-4.17%) ⬇️
products/jbrowse-web/src/util.ts 48.33% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cmdcolin cmdcolin added enhancement New feature or request and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Nov 9, 2022
@cmdcolin cmdcolin changed the title Move ErrorBoundary so that track label still available to close track Move ErrorBoundary so that tracks/views that have crashed can be closed more easily Nov 14, 2022
@cmdcolin cmdcolin merged commit 33879b7 into main Nov 14, 2022
@cmdcolin cmdcolin deleted the move_err_boundary branch November 14, 2022 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant