Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in codebase using typos-cli #3359

Merged
merged 2 commits into from
Nov 30, 2022
Merged

Fix typos in codebase using typos-cli #3359

merged 2 commits into from
Nov 30, 2022

Conversation

cmdcolin
Copy link
Collaborator

Uses https://github.com/crate-ci/typos

It is impressively good at finding typos in variable names and prose

This also adds a github action for this check. A .ignore file specifies a list of files to ignore, not able to ignore a single line for now, but pretty much checks and fixes the whole codebase by running typos --write-changes in root dir

More fixes

Docs
@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Nov 30, 2022
@cmdcolin cmdcolin added enhancement New feature or request and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Nov 30, 2022
@cmdcolin
Copy link
Collaborator Author

the repo doesn't make it super clear but the tool appears to support most programming languages afaik

@codecov
Copy link

codecov bot commented Nov 30, 2022

Codecov Report

Merging #3359 (674a814) into main (14ea238) will not change coverage.
The diff coverage is 50.00%.

@@           Coverage Diff           @@
##             main    #3359   +/-   ##
=======================================
  Coverage   59.01%   59.01%           
=======================================
  Files         773      773           
  Lines       29439    29439           
  Branches     7116     7116           
=======================================
  Hits        17372    17372           
  Misses      11873    11873           
  Partials      194      194           
Impacted Files Coverage Δ
packages/core/data_adapters/BaseAdapter.ts 74.69% <ø> (ø)
...eElementTypes/renderers/ServerSideRendererType.tsx 46.00% <ø> (ø)
packages/core/util/formatFastaStrings.ts 100.00% <ø> (ø)
packages/core/util/tracks.ts 76.66% <ø> (ø)
...gins/alignments/src/PileupRenderer/configSchema.ts 50.00% <ø> (ø)
...c/BaseChordDisplay/models/BaseChordDisplayModel.ts 75.00% <ø> (ø)
...s/src/MCScanAnchorsAdapter/MCScanAnchorsAdapter.ts 82.60% <ø> (ø)
...SimpleAnchorsAdapter/MCScanSimpleAnchorsAdapter.ts 0.00% <ø> (ø)
...src/FromConfigAdapter/FromConfigSequenceAdapter.ts 78.26% <ø> (ø)
...t-view/src/DotplotRenderer/ComparativeRenderRpc.ts 0.00% <0.00%> (ø)
... and 22 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cmdcolin
Copy link
Collaborator Author

I think should be a good to go :) could check it out for our other codebases like apollo perhaps

@cmdcolin cmdcolin merged commit 4e69945 into main Nov 30, 2022
@cmdcolin cmdcolin deleted the typos_autofix branch November 30, 2022 17:07
@rbuels
Copy link
Contributor

rbuels commented Nov 30, 2022

wow this is really cool! nice find

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants