Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create remove-track CLI command #3363

Merged
merged 4 commits into from
Dec 1, 2022
Merged

Create remove-track CLI command #3363

merged 4 commits into from
Dec 1, 2022

Conversation

cmdcolin
Copy link
Collaborator

@cmdcolin cmdcolin commented Dec 1, 2022

Fixes #1253

Also does some other small refactoring around the CLI tests

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Dec 1, 2022
@cmdcolin cmdcolin added enhancement New feature or request and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Dec 1, 2022
@codecov
Copy link

codecov bot commented Dec 1, 2022

Codecov Report

Merging #3363 (42c4632) into main (4e69945) will increase coverage by 0.55%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #3363      +/-   ##
==========================================
+ Coverage   59.01%   59.56%   +0.55%     
==========================================
  Files         773      772       -1     
  Lines       29439    29414      -25     
  Branches     7116     7121       +5     
==========================================
+ Hits        17372    17520     +148     
+ Misses      11873    11700     -173     
  Partials      194      194              
Impacted Files Coverage Δ
products/jbrowse-cli/src/base.ts 82.50% <100.00%> (ø)
products/jbrowse-cli/src/commands/remove-track.ts 100.00% <100.00%> (ø)
...ts/jbrowse-cli/src/commands/set-default-session.ts 96.49% <100.00%> (ø)
products/jbrowse-cli/src/testUtil.ts 93.65% <100.00%> (+1.98%) ⬆️
products/jbrowse-img/src/index.test.js
products/jbrowse-img/src/parseArgv.test.js
...aseLinearDisplay/models/BaseLinearDisplayModel.tsx 86.71% <0.00%> (+0.69%) ⬆️
...FeatureRenderer/components/SvgFeatureRendering.tsx 76.84% <0.00%> (+1.05%) ⬆️
plugins/alignments/src/BamAdapter/BamAdapter.ts 73.45% <0.00%> (+1.76%) ⬆️
...src/SvgFeatureRenderer/components/FeatureLabel.tsx 80.00% <0.00%> (+2.50%) ⬆️
... and 8 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cmdcolin
Copy link
Collaborator Author

cmdcolin commented Dec 1, 2022

the whole thing about crashing session cause of a removed track is hard to advise users on properly but I figure this PR is otherwise good to go

@cmdcolin cmdcolin merged commit 4361f01 into main Dec 1, 2022
@cmdcolin cmdcolin deleted the remove_track branch December 1, 2022 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create remove-track CLI command
1 participant