-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create base "Dialog" component to standardize dialogs across codebase #3368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs label triage
Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal)
label
Dec 2, 2022
cmdcolin
added
internal
and removed
needs label triage
Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal)
labels
Dec 2, 2022
cmdcolin
force-pushed
the
more_dialog_actions
branch
from
December 2, 2022 04:23
1ea841c
to
04c1976
Compare
Codecov Report
@@ Coverage Diff @@
## main #3368 +/- ##
==========================================
+ Coverage 59.72% 59.87% +0.15%
==========================================
Files 776 777 +1
Lines 29520 29417 -103
Branches 7157 7114 -43
==========================================
- Hits 17631 17614 -17
+ Misses 11693 11612 -81
+ Partials 196 191 -5
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
cmdcolin
force-pushed
the
more_dialog_actions
branch
2 times, most recently
from
December 2, 2022 17:28
4457ab0
to
e79e85b
Compare
cmdcolin
force-pushed
the
more_dialog_actions
branch
2 times, most recently
from
December 2, 2022 20:12
541dc43
to
18c8ffb
Compare
cmdcolin
force-pushed
the
more_dialog_actions
branch
from
December 2, 2022 22:46
18c8ffb
to
74b3851
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a base "Dialog" class here. It essentially provides a standard close button, and scopedcssbaseline which is helpful in embedded
Fixes #2465