Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create base "Dialog" component to standardize dialogs across codebase #3368

Merged
merged 8 commits into from
Dec 2, 2022

Conversation

cmdcolin
Copy link
Collaborator

@cmdcolin cmdcolin commented Dec 2, 2022

This PR adds a base "Dialog" class here. It essentially provides a standard close button, and scopedcssbaseline which is helpful in embedded

Fixes #2465

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Dec 2, 2022
@cmdcolin cmdcolin added internal and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Dec 2, 2022
@codecov
Copy link

codecov bot commented Dec 2, 2022

Codecov Report

Merging #3368 (18c8ffb) into main (cef4792) will increase coverage by 0.15%.
The diff coverage is 60.09%.

❗ Current head 18c8ffb differs from pull request most recent head 74b3851. Consider uploading reports for the commit 74b3851 to get more accurate results

@@            Coverage Diff             @@
##             main    #3368      +/-   ##
==========================================
+ Coverage   59.72%   59.87%   +0.15%     
==========================================
  Files         776      777       +1     
  Lines       29520    29417     -103     
  Branches     7157     7114      -43     
==========================================
- Hits        17631    17614      -17     
+ Misses      11693    11612      -81     
+ Partials      196      191       -5     
Impacted Files Coverage Δ
...aseFeatureWidget/SequenceFeatureSettingsDialog.tsx 6.25% <0.00%> (+1.25%) ⬆️
...ages/core/BaseFeatureWidget/SequenceHelpDialog.tsx 0.00% <0.00%> (-10.00%) ⬇️
packages/core/ui/FactoryResetDialog.tsx 22.22% <0.00%> (ø)
packages/core/ui/ReturnToImportFormDialog.tsx 0.00% <ø> (-8.34%) ⬇️
...rPileupDisplay/components/ColorByModifications.tsx 0.00% <0.00%> (ø)
.../src/LinearPileupDisplay/components/ColorByTag.tsx 100.00% <ø> (ø)
...src/LinearPileupDisplay/components/FilterByTag.tsx 0.00% <ø> (ø)
...inearPileupDisplay/components/SetFeatureHeight.tsx 0.00% <ø> (ø)
...rc/LinearPileupDisplay/components/SetMaxHeight.tsx 0.00% <ø> (ø)
...s/src/LinearPileupDisplay/components/SortByTag.tsx 0.00% <ø> (ø)
... and 32 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cmdcolin cmdcolin force-pushed the more_dialog_actions branch 2 times, most recently from 4457ab0 to e79e85b Compare December 2, 2022 17:28
@cmdcolin cmdcolin force-pushed the more_dialog_actions branch 2 times, most recently from 541dc43 to 18c8ffb Compare December 2, 2022 20:12
@cmdcolin cmdcolin merged commit f096f8a into main Dec 2, 2022
@cmdcolin cmdcolin deleted the more_dialog_actions branch December 2, 2022 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better styling on embedded lgv view dialog boxes
1 participant