Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rendering and clicking synteny features when using MainThreadRpc #3377

Merged
merged 1 commit into from
Dec 6, 2022

Conversation

cmdcolin
Copy link
Collaborator

@cmdcolin cmdcolin commented Dec 6, 2022

Fixes #3376

Basically it trying to pass a SimpleFeature as argument to the SimpleFeature constructor instead of a SimpleFeatureSerialized due to a confusing about hydration.

It might be that a follow up could refactor LinearSyntenyRendering to not use server side rendering, because it doesn't actually benefit from this at all (it just makes a blank react component in the web worker but all the drawing is done on the main thread). That basically means it could just use a RPC call to fetch the features instead and be conceptually simpler

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Dec 6, 2022
@cmdcolin cmdcolin added bug Something isn't working and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Dec 6, 2022
@codecov
Copy link

codecov bot commented Dec 6, 2022

Codecov Report

Merging #3377 (aac5c24) into main (7f60eb6) will increase coverage by 0.17%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##             main    #3377      +/-   ##
==========================================
+ Coverage   59.87%   60.05%   +0.17%     
==========================================
  Files         777      777              
  Lines       29416    29418       +2     
  Branches     7114     7117       +3     
==========================================
+ Hits        17614    17668      +54     
+ Misses      11611    11559      -52     
  Partials      191      191              
Impacted Files Coverage Δ
...tenyRenderer/components/LinearSyntenyRendering.tsx 66.49% <66.66%> (+13.53%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cmdcolin
Copy link
Collaborator Author

cmdcolin commented Dec 6, 2022

can merge for now, it's sort of odd but we can look at changing from serversiderenderer->rpc fetch features separately

@cmdcolin cmdcolin merged commit eca394c into main Dec 6, 2022
@cmdcolin cmdcolin deleted the fix_synteny_mainthread branch December 6, 2022 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clicking on features in synteny view fails in MainThreadRpc
1 participant