Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add method for cache busting requests to the config file in jbrowse-web #3381

Merged
merged 1 commit into from
Dec 8, 2022

Conversation

cmdcolin
Copy link
Collaborator

@cmdcolin cmdcolin commented Dec 6, 2022

We need to look at e.g. a global variable to check this, as there is no configuration file otherwise available to get this from

xref #3045

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Dec 6, 2022
@cmdcolin cmdcolin added enhancement New feature or request and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Dec 6, 2022
@cmdcolin
Copy link
Collaborator Author

cmdcolin commented Dec 6, 2022

could also consider enabling by default

@codecov
Copy link

codecov bot commented Dec 6, 2022

Codecov Report

Merging #3381 (61c8ae4) into main (eca394c) will increase coverage by 0.00%.
The diff coverage is 66.66%.

@@           Coverage Diff           @@
##             main    #3381   +/-   ##
=======================================
  Coverage   60.05%   60.05%           
=======================================
  Files         777      777           
  Lines       29418    29420    +2     
  Branches     7117     7118    +1     
=======================================
+ Hits        17667    17669    +2     
  Misses      11560    11560           
  Partials      191      191           
Impacted Files Coverage Δ
products/jbrowse-web/src/SessionLoader.ts 63.80% <66.66%> (-0.13%) ⬇️
...rative-view/src/ServerSideRenderedBlockContent.tsx 66.66% <0.00%> (+4.16%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cmdcolin
Copy link
Collaborator Author

cmdcolin commented Dec 8, 2022

might go ahead and merge

@cmdcolin cmdcolin merged commit 39c687a into main Dec 8, 2022
@cmdcolin cmdcolin deleted the cache_buster branch December 8, 2022 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant