Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize prefix size for text indexing automatically #3385

Merged
merged 9 commits into from
Dec 8, 2022
Merged

Conversation

cmdcolin
Copy link
Collaborator

@cmdcolin cmdcolin commented Dec 8, 2022

Pairs with this PR to provide an automated search for a prefix size that has reasonably sized bins GMOD/ixixx-js#16

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Dec 8, 2022
@cmdcolin cmdcolin added enhancement New feature or request and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Dec 8, 2022
@cmdcolin cmdcolin changed the title Optimize prefix size for text indexing and misc refactors Optimize prefix size for text indexing automatically Dec 8, 2022
@cmdcolin
Copy link
Collaborator Author

cmdcolin commented Dec 8, 2022

related to issues like #3379

@cmdcolin cmdcolin force-pushed the refactor_cli branch 2 times, most recently from b2da7d4 to fcf5619 Compare December 8, 2022 20:32
@cmdcolin
Copy link
Collaborator Author

cmdcolin commented Dec 8, 2022

will need GMOD/ixixx-js#16 to pass test

@rbuels
Copy link
Contributor

rbuels commented Dec 8, 2022

What a great idea!

@codecov
Copy link

codecov bot commented Dec 8, 2022

Codecov Report

Merging #3385 (e3c1a82) into main (91d6e82) will increase coverage by 0.07%.
The diff coverage is 80.59%.

@@            Coverage Diff             @@
##             main    #3385      +/-   ##
==========================================
+ Coverage   60.04%   60.12%   +0.07%     
==========================================
  Files         777      776       -1     
  Lines       29416    29389      -27     
  Branches     7117     7115       -2     
==========================================
+ Hits        17664    17670       +6     
+ Misses      11561    11528      -33     
  Partials      191      191              
Impacted Files Coverage Δ
products/jbrowse-cli/src/commands/text-index.ts 70.94% <74.50%> (-0.39%) ⬇️
products/jbrowse-cli/src/commands/add-assembly.ts 89.16% <100.00%> (+0.13%) ⬆️
products/jbrowse-cli/src/testUtil.ts 93.84% <100.00%> (+0.19%) ⬆️
products/jbrowse-cli/src/types/common.ts 71.05% <100.00%> (-1.45%) ⬇️
products/jbrowse-cli/src/types/gff3Adapter.ts 96.96% <100.00%> (ø)
products/jbrowse-cli/src/types/vcfAdapter.ts 97.50% <100.00%> (ø)
products/jbrowse-web/src/util.ts 48.33% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cmdcolin cmdcolin merged commit 4ebc3ad into main Dec 8, 2022
@cmdcolin cmdcolin deleted the refactor_cli branch December 8, 2022 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants