Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small UI tweaks for add track workflow #3387

Merged
merged 2 commits into from
Dec 11, 2022
Merged

Small UI tweaks for add track workflow #3387

merged 2 commits into from
Dec 11, 2022

Conversation

cmdcolin
Copy link
Collaborator

@cmdcolin cmdcolin commented Dec 10, 2022

  • Use @jbrowse/core/ui/AssemblySelector for the add track workflow instead of custom assembly selector component
  • Make it so the AssemblySelector isn't so eager to reach for localStorage to enable the above
  • Refactor the categories code for track adapter selector in add track workflow
  • Make it so adapterMetadata has optional slots instead of |null
  • Fix bug running action in the render instead of in useEffect in ConfirmTrack xref Bug: too hard to fix "Cannot update a component from inside the function body of a different component." facebook/react#18178 (comment)
  • Make the add-track workflow selection read "Default add track workflow" instead of just Default, which stands out a little more visually
  • Use variant=contained select boxes in add track workflow, I think it makes them more clearly a select drop box

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Dec 10, 2022
@cmdcolin cmdcolin added enhancement New feature or request and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Dec 10, 2022
@codecov
Copy link

codecov bot commented Dec 10, 2022

Codecov Report

Merging #3387 (ce2f160) into main (0dfd9bf) will increase coverage by 0.02%.
The diff coverage is 63.26%.

@@            Coverage Diff             @@
##             main    #3387      +/-   ##
==========================================
+ Coverage   59.32%   59.35%   +0.02%     
==========================================
  Files         812      819       +7     
  Lines       29761    29757       -4     
  Branches     7160     7154       -6     
==========================================
+ Hits        17656    17661       +5     
+ Misses      11917    11908       -9     
  Partials      188      188              
Impacted Files Coverage Δ
packages/core/pluggableElementTypes/AdapterType.ts 83.33% <ø> (ø)
plugins/alignments/src/HtsgetBamAdapter/index.ts 75.00% <ø> (ø)
plugins/alignments/src/SNPCoverageAdapter/index.ts 100.00% <ø> (ø)
...ins/comparative-adapters/src/ChainAdapter/index.ts 75.00% <ø> (ø)
...ins/comparative-adapters/src/DeltaAdapter/index.ts 75.00% <ø> (ø)
...arative-adapters/src/MCScanAnchorsAdapter/index.ts 75.00% <ø> (ø)
...e-adapters/src/MCScanSimpleAnchorsAdapter/index.ts 75.00% <ø> (ø)
...s/comparative-adapters/src/MashMapAdapter/index.ts 75.00% <ø> (ø)
...ugins/comparative-adapters/src/PAFAdapter/index.ts 100.00% <ø> (ø)
...ugins/config/src/FromConfigAdapter/configSchema.ts 50.00% <ø> (ø)
... and 27 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cmdcolin
Copy link
Collaborator Author

also suggests moving adapterMetadata.displayName to just displayName

@cmdcolin cmdcolin merged commit a68d388 into main Dec 11, 2022
@cmdcolin cmdcolin deleted the refactor_add_track branch December 11, 2022 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant