Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix positioning within large alignments for query->target LGV synteny navigation #3390

Merged
merged 1 commit into from
Dec 11, 2022

Conversation

cmdcolin
Copy link
Collaborator

Needs to perform the "oriented" remap of the CIGAR string (swap deletions and insertions)

Probably fix for issue mentioned in chat https://gitter.im/GMOD/jbrowse2?at=6393a1d9b9b687534188b8ea

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Dec 11, 2022
@cmdcolin cmdcolin added bug Something isn't working and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Dec 11, 2022
@codecov
Copy link

codecov bot commented Dec 11, 2022

Codecov Report

Merging #3390 (6a6f6d4) into main (2869340) will decrease coverage by 0.03%.
The diff coverage is 8.16%.

❗ Current head 6a6f6d4 differs from pull request most recent head 05b457a. Consider uploading reports for the commit 05b457a to get more accurate results

@@            Coverage Diff             @@
##             main    #3390      +/-   ##
==========================================
- Coverage   60.36%   60.33%   -0.04%     
==========================================
  Files         819      819              
  Lines       29754    29772      +18     
  Branches     7151     7155       +4     
==========================================
  Hits        17962    17962              
- Misses      11605    11623      +18     
  Partials      187      187              
Impacted Files Coverage Δ
...lugins/alignments/src/BamAdapter/MismatchParser.ts 73.86% <5.55%> (-15.16%) ⬇️
...ve-view/src/LGVSyntenyDisplay/stateModelFactory.ts 4.10% <8.33%> (-0.12%) ⬇️
.../comparative-adapters/src/PAFAdapter/PAFAdapter.ts 63.35% <100.00%> (+8.02%) ⬆️
products/jbrowse-web/src/util.ts 48.33% <0.00%> (-1.67%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cmdcolin cmdcolin force-pushed the fix_reverse_orientation_synteny branch from 6a6f6d4 to 05b457a Compare December 11, 2022 11:12
@cmdcolin cmdcolin changed the title Fix query->target for LGV synteny navigation Fix query->target LGV synteny navigation Dec 11, 2022
@cmdcolin cmdcolin changed the title Fix query->target LGV synteny navigation Fix CIGAR positioning within large alignments for query->target LGV synteny navigation Dec 11, 2022
@cmdcolin cmdcolin changed the title Fix CIGAR positioning within large alignments for query->target LGV synteny navigation Fix positioning within large alignments for query->target LGV synteny navigation Dec 11, 2022
@cmdcolin cmdcolin merged commit 30e9e80 into main Dec 11, 2022
@cmdcolin cmdcolin deleted the fix_reverse_orientation_synteny branch December 11, 2022 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant