Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce peerDependency warnings from installing dev environment #3400

Merged
merged 2 commits into from
Dec 15, 2022
Merged

Reduce peerDependency warnings from installing dev environment #3400

merged 2 commits into from
Dec 15, 2022

Conversation

cmdcolin
Copy link
Collaborator

This really only affects the dev environment, and most of these are not real problems probably, but it can help to make the package manager happy and reduce error message overload. Most of these are fixed by adding some deps to root devDeps.

Before, 185 warnings

warning "@craco/craco > autoprefixer@10.4.13" has unmet peer dependency "postcss@^8.1.0".
warning " > @emotion/react@11.10.5" has unmet peer dependency "react@>=16.8.0".
warning "@emotion/react > @emotion/use-insertion-effect-with-fallbacks@1.0.0" has unmet peer dependency "react@>=16.8.0".
warning " > @emotion/styled@11.10.5" has unmet peer dependency "react@>=16.8.0".
warning " > @mui/material@5.10.17" has unmet peer dependency "react@^17.0.0 || ^18.0.0".
warning " > @mui/material@5.10.17" has unmet peer dependency "react-dom@^17.0.0 || ^18.0.0".
warning "@mui/material > @mui/base@5.0.0-alpha.109" has unmet peer dependency "react@^17.0.0 || ^18.0.0".
warning "@mui/material > @mui/base@5.0.0-alpha.109" has unmet peer dependency "react-dom@^17.0.0 || ^18.0.0".
warning "@mui/material > @mui/system@5.10.17" has unmet peer dependency "react@^17.0.0 || ^18.0.0".
warning "@mui/material > @mui/utils@5.10.16" has unmet peer dependency "react@^17.0.0 || ^18.0.0".
warning "@mui/material > react-transition-group@4.4.5" has unmet peer dependency "react@>=16.6.0".
warning "@mui/material > react-transition-group@4.4.5" has unmet peer dependency "react-dom@>=16.6.0".
warning "@mui/material > @mui/system > @mui/private-theming@5.10.16" has unmet peer dependency "react@^17.0.0 || ^18.0.0".
warning "@mui/material > @mui/system > @mui/styled-engine@5.10.16" has unmet peer dependency "react@^17.0.0 || ^18.0.0".
warning " > @storybook/addons@6.5.14" has unmet peer dependency "react@^16.8.0 || ^17.0.0 || ^18.0.0".
warning " > @storybook/addons@6.5.14" has unmet peer dependency "react-dom@^16.8.0 || ^17.0.0 || ^18.0.0".
warning "@storybook/addon-actions > @storybook/api@6.5.14" has unmet peer dependency "react@^16.8.0 || ^17.0.0 || ^18.0.0".
warning "@storybook/addon-actions > @storybook/api@6.5.14" has unmet peer dependency "react-dom@^16.8.0 || ^17.0.0 || ^18.0.0".
warning "@storybook/addon-actions > @storybook/components@6.5.14" has unmet peer dependency "react@^16.8.0 || ^17.0.0 || ^18.0.0".
warning "@storybook/addon-actions > @storybook/components@6.5.14" has unmet peer dependency "react-dom@^16.8.0 || ^17.0.0 || ^18.0.0".
warning "@storybook/addon-actions > @storybook/theming@6.5.14" has unmet peer dependency "react@^16.8.0 || ^17.0.0 || ^18.0.0".
warning "@storybook/addon-actions > @storybook/theming@6.5.14" has unmet peer dependency "react-dom@^16.8.0 || ^17.0.0 || ^18.0.0".
warning "@storybook/addon-actions > react-inspector@5.1.1" has unmet peer dependency "react@^16.8.4 || ^17.0.0".
warning "@storybook/addon-links > @storybook/router@6.5.14" has unmet peer dependency "react@^16.8.0 || ^17.0.0 || ^18.0.0".
warning "@storybook/addon-links > @storybook/router@6.5.14" has unmet peer dependency "react-dom@^16.8.0 || ^17.0.0 || ^18.0.0".
warning "@storybook/addon-docs > @mdx-js/react@1.6.22" has unmet peer dependency "react@^16.13.1 || ^17.0.0".
warning "@storybook/addon-docs > @storybook/core-common@6.5.14" has unmet peer dependency "react@^16.8.0 || ^17.0.0 || ^18.0.0".
warning "@storybook/addon-docs > @storybook/core-common@6.5.14" has unmet peer dependency "react-dom@^16.8.0 || ^17.0.0 || ^18.0.0".
warning "@storybook/addon-docs > @storybook/preview-web@6.5.14" has unmet peer dependency "react@^16.8.0 || ^17.0.0 || ^18.0.0".
warning "@storybook/addon-docs > @storybook/preview-web@6.5.14" has unmet peer dependency "react-dom@^16.8.0 || ^17.0.0 || ^18.0.0".
warning "@storybook/addon-docs > @storybook/source-loader@6.5.14" has unmet peer dependency "react@^16.8.0 || ^17.0.0 || ^18.0.0".
warning "@storybook/addon-docs > @storybook/source-loader@6.5.14" has unmet peer dependency "react-dom@^16.8.0 || ^17.0.0 || ^18.0.0".
warning "@storybook/addon-docs > @storybook/store@6.5.14" has unmet peer dependency "react@^16.8.0 || ^17.0.0 || ^18.0.0".
warning "@storybook/addon-docs > @storybook/store@6.5.14" has unmet peer dependency "react-dom@^16.8.0 || ^17.0.0 || ^18.0.0".
warning "@storybook/addon-docs > babel-loader@8.3.0" has unmet peer dependency "webpack@>=2".
warning " > @storybook/builder-webpack5@6.5.14" has unmet peer dependency "react@^16.8.0 || ^17.0.0 || ^18.0.0".
warning " > @storybook/builder-webpack5@6.5.14" has unmet peer dependency "react-dom@^16.8.0 || ^17.0.0 || ^18.0.0".
warning "@storybook/builder-webpack5 > @storybook/client-api@6.5.14" has unmet peer dependency "react@^16.8.0 || ^17.0.0 || ^18.0.0".
warning "@storybook/builder-webpack5 > @storybook/client-api@6.5.14" has unmet peer dependency "react-dom@^16.8.0 || ^17.0.0 || ^18.0.0".
warning " > @storybook/manager-webpack5@6.5.14" has unmet peer dependency "react@^16.8.0 || ^17.0.0 || ^18.0.0".
warning " > @storybook/manager-webpack5@6.5.14" has unmet peer dependency "react-dom@^16.8.0 || ^17.0.0 || ^18.0.0".
warning "@storybook/manager-webpack5 > @storybook/core-client@6.5.14" has unmet peer dependency "react@^16.8.0 || ^17.0.0 || ^18.0.0".
warning "@storybook/manager-webpack5 > @storybook/core-client@6.5.14" has unmet peer dependency "react-dom@^16.8.0 || ^17.0.0 || ^18.0.0".
warning "@storybook/manager-webpack5 > @storybook/ui@6.5.14" has unmet peer dependency "react@^16.8.0 || ^17.0.0 || ^18.0.0".
warning "@storybook/manager-webpack5 > @storybook/ui@6.5.14" has unmet peer dependency "react-dom@^16.8.0 || ^17.0.0 || ^18.0.0".
warning " > @storybook/react@6.5.14" has unmet peer dependency "react@^16.8.0 || ^17.0.0 || ^18.0.0".
warning " > @storybook/react@6.5.14" has unmet peer dependency "react-dom@^16.8.0 || ^17.0.0 || ^18.0.0".
warning " > @storybook/react@6.5.14" has unmet peer dependency "require-from-string@^2.0.2".
warning "@storybook/react > @storybook/core@6.5.14" has unmet peer dependency "react@^16.8.0 || ^17.0.0 || ^18.0.0".
warning "@storybook/react > @storybook/core@6.5.14" has unmet peer dependency "react-dom@^16.8.0 || ^17.0.0 || ^18.0.0".
warning "@storybook/react > react-element-to-jsx-string@14.3.4" has unmet peer dependency "react@^0.14.8 || ^15.0.1 || ^16.0.0 || ^17.0.1".
warning "@storybook/react > react-element-to-jsx-string@14.3.4" has unmet peer dependency "react-dom@^0.14.8 || ^15.0.1 || ^16.0.0 || ^17.0.1".
warning "@storybook/react > @storybook/core > @storybook/core-server@6.5.14" has unmet peer dependency "react@^16.8.0 || ^17.0.0 || ^18.0.0".
warning "@storybook/react > @storybook/core > @storybook/core-server@6.5.14" has unmet peer dependency "react-dom@^16.8.0 || ^17.0.0 || ^18.0.0".
warning "@storybook/react > @storybook/core > @storybook/core-server > @storybook/builder-webpack4@6.5.14" has unmet peer dependency "react@^16.8.0 || ^17.0.0 || ^18.0.0".
warning "@storybook/react > @storybook/core > @storybook/core-server > @storybook/builder-webpack4@6.5.14" has unmet peer dependency "react-dom@^16.8.0 || ^17.0.0 || ^18.0.0".
warning "@storybook/react > @storybook/core > @storybook/core-server > @storybook/manager-webpack4@6.5.14" has unmet peer dependency "react@^16.8.0 || ^17.0.0 || ^18.0.0".
warning "@storybook/react > @storybook/core > @storybook/core-server > @storybook/manager-webpack4@6.5.14" has unmet peer dependency "react-dom@^16.8.0 || ^17.0.0 || ^18.0.0".
warning " > file-loader@6.2.0" has unmet peer dependency "webpack@^4.0.0 || ^5.0.0".
warning " > @testing-library/react@12.1.5" has unmet peer dependency "react@<18.0.0".
warning " > @testing-library/react@12.1.5" has unmet peer dependency "react-dom@<18.0.0".
warning " > @typescript-eslint/parser@5.46.0" has unmet peer dependency "eslint@^6.0.0 || ^7.0.0 || ^8.0.0".
warning " > babel-loader@9.1.0" has unmet peer dependency "webpack@>=5".
warning " > eslint-config-prettier@8.5.0" has unmet peer dependency "eslint@>=7.0.0".
warning " > eslint-config-react-app@7.0.1" has unmet peer dependency "eslint@^8.0.0".
warning "eslint-config-react-app > @babel/eslint-parser@7.19.1" has unmet peer dependency "eslint@^7.5.0 || ^8.0.0".
warning "eslint-config-react-app > @typescript-eslint/eslint-plugin@5.46.0" has unmet peer dependency "eslint@^6.0.0 || ^7.0.0 || ^8.0.0".
warning "eslint-config-react-app > eslint-plugin-flowtype@8.0.3" has unmet peer dependency "@babel/plugin-syntax-flow@^7.14.5".
warning "eslint-config-react-app > eslint-plugin-flowtype@8.0.3" has unmet peer dependency "@babel/plugin-transform-react-jsx@^7.14.9".
warning "eslint-config-react-app > eslint-plugin-flowtype@8.0.3" has unmet peer dependency "eslint@^8.1.0".
warning "eslint-config-react-app > eslint-plugin-import@2.26.0" has unmet peer dependency "eslint@^2 || ^3 || ^4 || ^5 || ^6 || ^7.2.0 || ^8".
warning "eslint-config-react-app > eslint-plugin-jest@25.7.0" has unmet peer dependency "eslint@^6.0.0 || ^7.0.0 || ^8.0.0".
warning "eslint-config-react-app > eslint-plugin-jsx-a11y@6.6.1" has unmet peer dependency "eslint@^3 || ^4 || ^5 || ^6 || ^7 || ^8".
warning "eslint-config-react-app > eslint-plugin-react@7.31.11" has unmet peer dependency "eslint@^3 || ^4 || ^5 || ^6 || ^7 || ^8".
warning " > eslint-plugin-react-hooks@4.6.0" has unmet peer dependency "eslint@^3.0.0 || ^4.0.0 || ^5.0.0 || ^6.0.0 || ^7.0.0 || ^8.0.0-0".
warning "eslint-config-react-app > eslint-plugin-testing-library@5.9.1" has unmet peer dependency "eslint@^7.5.0 || ^8.0.0".
warning "eslint-config-react-app > @typescript-eslint/eslint-plugin > @typescript-eslint/type-utils@5.46.0" has unmet peer dependency "eslint@*".
warning "eslint-config-react-app > @typescript-eslint/eslint-plugin > @typescript-eslint/utils@5.46.0" has unmet peer dependency "eslint@^6.0.0 || ^7.0.0 || ^8.0.0".
warning "eslint-config-react-app > eslint-plugin-jest > @typescript-eslint/experimental-utils@5.46.0" has unmet peer dependency "eslint@^6.0.0 || ^7.0.0 || ^8.0.0".
warning " > eslint-plugin-cypress@2.12.1" has unmet peer dependency "eslint@>= 3.2.1".
warning " > eslint-plugin-prettier@4.2.1" has unmet peer dependency "eslint@>=7.28.0".
warning " > mobx-react@7.6.0" has unmet peer dependency "react@^16.8.0 || ^17 || ^18".
warning "mobx-react > mobx-react-lite@3.4.0" has unmet peer dependency "react@^16.8.0 || ^17 || ^18".
warning " > node-polyfill-webpack-plugin@2.0.1" has unmet peer dependency "webpack@>=5".
warning " > react-scripts@5.0.1" has unmet peer dependency "react@>= 16".
warning " > webpack-dev-server@4.11.1" has unmet peer dependency "webpack@^4.37.0 || ^5.0.0".
warning " > ts-loader@9.4.2" has unmet peer dependency "webpack@^5.0.0".
warning " > webpack-cli@5.0.1" has unmet peer dependency "webpack@5.x.x".
warning "webpack-cli > @webpack-cli/configtest@2.0.1" has unmet peer dependency "webpack@5.x.x".
warning "webpack-cli > @webpack-cli/info@2.0.1" has unmet peer dependency "webpack@5.x.x".
warning "webpack-cli > @webpack-cli/serve@2.0.1" has unmet peer dependency "webpack@5.x.x".
warning " > @jbrowse/core@2.2.2" has unmet peer dependency "@mui/x-data-grid@^5.0.0".
warning " > @jbrowse/core@2.2.2" has unmet peer dependency "react@>=16.8.0".
warning " > @jbrowse/core@2.2.2" has unmet peer dependency "react-dom@>=16.8.0".
warning " > @jbrowse/core@2.2.2" has unmet peer dependency "tss-react@^3.0.0".
warning " > @jbrowse/text-indexing@2.2.2" has incorrect peer dependency "mobx@^5.0.0".
warning " > @jbrowse/text-indexing@2.2.2" has incorrect peer dependency "mobx-react@^6.0.0".
warning " > @jbrowse/text-indexing@2.2.2" has unmet peer dependency "react@^17.0.0".
warning " > @jbrowse/text-indexing@2.2.2" has unmet peer dependency "react-dom@^17.0.0".
warning " > @jbrowse/react-circular-genome-view@2.2.2" has unmet peer dependency "react@>=16.8.0".
warning " > @jbrowse/react-linear-genome-view@2.2.2" has unmet peer dependency "react@>=16.8.0".
warning " > @jbrowse/plugin-alignments@2.2.2" has unmet peer dependency "react@>=16.8.0".
warning " > @jbrowse/plugin-alignments@2.2.2" has unmet peer dependency "tss-react@^3.0.0".
warning " > @jbrowse/plugin-arc@2.2.2" has unmet peer dependency "react@>=16.8.0".
warning " > @jbrowse/plugin-authentication@2.2.2" has unmet peer dependency "crypto-js@^3.0.0".
warning " > @jbrowse/plugin-authentication@2.2.2" has incorrect peer dependency "electron@^15.0.0".
warning " > @jbrowse/plugin-authentication@2.2.2" has unmet peer dependency "generic-filehandle@^3.0.0".
warning " > @jbrowse/plugin-authentication@2.2.2" has unmet peer dependency "react@>=16.8.0".
warning " > @jbrowse/plugin-authentication@2.2.2" has unmet peer dependency "react-dom@>=16.8.0".
warning " > @jbrowse/plugin-breakpoint-split-view@2.2.2" has unmet peer dependency "react@>=16.8.4".
warning " > @jbrowse/plugin-breakpoint-split-view@2.2.2" has unmet peer dependency "tss-react@^3.0.0".
warning " > @jbrowse/plugin-circular-view@2.2.2" has unmet peer dependency "react@>=16.8.0".
warning " > @jbrowse/plugin-circular-view@2.2.2" has unmet peer dependency "react-dom@>=16.8.0".
warning " > @jbrowse/plugin-circular-view@2.2.2" has unmet peer dependency "tss-react@^3.0.0".
warning " > @jbrowse/plugin-comparative-adapters@2.2.2" has unmet peer dependency "react@>=16.8.0".
warning " > @jbrowse/plugin-comparative-adapters@2.2.2" has unmet peer dependency "react-dom@>=16.8.0".
warning " > @jbrowse/plugin-config@2.2.2" has unmet peer dependency "react@>=16.8.0".
warning " > @jbrowse/plugin-config@2.2.2" has unmet peer dependency "react-dom@>=16.8.0".
warning " > @jbrowse/plugin-config@2.2.2" has unmet peer dependency "tss-react@^3.0.0".
warning " > @jbrowse/plugin-data-management@2.2.2" has unmet peer dependency "react@>=16.8.0".
warning " > @jbrowse/plugin-data-management@2.2.2" has unmet peer dependency "tss-react@^3.0.0".
warning " > @jbrowse/plugin-dotplot-view@2.2.2" has incorrect peer dependency "@jbrowse/plugin-alignments@^4.12.2".
warning " > @jbrowse/plugin-dotplot-view@2.2.2" has unmet peer dependency "react@>=16.8.0".
warning " > @jbrowse/plugin-dotplot-view@2.2.2" has unmet peer dependency "react-dom@>=16.8.0".
warning " > @jbrowse/plugin-dotplot-view@2.2.2" has unmet peer dependency "tss-react@^3.0.0".
warning " > @jbrowse/plugin-gccontent@2.2.2" has unmet peer dependency "react@>=16.8.0".
warning " > @jbrowse/plugin-gff3@2.2.2" has unmet peer dependency "react@>=16.8.0".
warning " > @jbrowse/plugin-grid-bookmark@2.2.2" has unmet peer dependency "@mui/x-data-grid@^5.0.1".
warning " > @jbrowse/plugin-grid-bookmark@2.2.2" has unmet peer dependency "react@>=16.8.0".
warning " > @jbrowse/plugin-grid-bookmark@2.2.2" has unmet peer dependency "tss-react@^3.0.0".
warning " > @jbrowse/plugin-gtf@2.2.2" has unmet peer dependency "react@>=16.8.0".
warning " > @jbrowse/plugin-hic@2.2.2" has unmet peer dependency "react@>=16.8.0".
warning " > @jbrowse/plugin-jobs-management@2.2.2" has unmet peer dependency "react@>=16.8.0".
warning " > @jbrowse/plugin-jobs-management@2.2.2" has unmet peer dependency "tss-react@^3.0.0".
warning " > @jbrowse/plugin-linear-comparative-view@2.2.2" has unmet peer dependency "react@>=16.8.0".
warning " > @jbrowse/plugin-linear-comparative-view@2.2.2" has unmet peer dependency "react-dom@>=16.8.0".
warning " > @jbrowse/plugin-linear-comparative-view@2.2.2" has unmet peer dependency "tss-react@^3.0.0".
warning " > @jbrowse/plugin-linear-genome-view@2.2.2" has unmet peer dependency "react@>=16.8.0".
warning " > @jbrowse/plugin-linear-genome-view@2.2.2" has unmet peer dependency "react-dom@>=16.8.0".
warning " > @jbrowse/plugin-linear-genome-view@2.2.2" has unmet peer dependency "react-error-boundary@^3.0.0".
warning " > @jbrowse/plugin-linear-genome-view@2.2.2" has unmet peer dependency "tss-react@^3.0.0".
warning " > @jbrowse/plugin-lollipop@2.2.2" has unmet peer dependency "react@>=16.8.0".
warning " > @jbrowse/plugin-menus@2.2.2" has unmet peer dependency "react@>=16.8.0".
warning " > @jbrowse/plugin-menus@2.2.2" has unmet peer dependency "react-dom@>=16.8.0".
warning " > @jbrowse/plugin-menus@2.2.2" has unmet peer dependency "tss-react@^3.0.0".
warning " > @jbrowse/plugin-protein@2.2.2" has unmet peer dependency "react@>=16.8.0".
warning " > @jbrowse/plugin-sequence@2.2.2" has unmet peer dependency "react@>=16.8.0".
warning " > @jbrowse/plugin-spreadsheet-view@2.2.2" has unmet peer dependency "react@>=16.8.0".
warning " > @jbrowse/plugin-spreadsheet-view@2.2.2" has unmet peer dependency "react-dom@>=16.8.0".
warning " > @jbrowse/plugin-spreadsheet-view@2.2.2" has unmet peer dependency "tss-react@^3.0.0".
warning " > @jbrowse/plugin-sv-inspector@2.2.2" has unmet peer dependency "react@>=16.8.0".
warning " > @jbrowse/plugin-sv-inspector@2.2.2" has unmet peer dependency "react-dom@>=16.8.0".
warning " > @jbrowse/plugin-sv-inspector@2.2.2" has unmet peer dependency "tss-react@^3.0.0".
warning " > @jbrowse/plugin-svg@2.2.2" has unmet peer dependency "react@>=16.8.0".
warning " > @jbrowse/plugin-text-indexing@2.2.2" has unmet peer dependency "react@>=16.8.0".
warning " > @jbrowse/plugin-trackhub-registry@2.2.2" has unmet peer dependency "dompurify@^2.0.11".
warning " > @jbrowse/plugin-trackhub-registry@2.2.2" has unmet peer dependency "react@>=16.8.0".
warning " > @jbrowse/plugin-trackhub-registry@2.2.2" has unmet peer dependency "tss-react@^3.0.0".
warning " > @jbrowse/plugin-trix@2.2.2" has unmet peer dependency "react@>=16.8.0".
warning " > @jbrowse/plugin-variants@2.2.2" has unmet peer dependency "react@>=16.8.0".
warning " > @jbrowse/plugin-variants@2.2.2" has unmet peer dependency "tss-react@^3.0.0".
warning " > @jbrowse/plugin-wiggle@2.2.2" has unmet peer dependency "@mui/x-data-grid@^5.0.1".
warning " > @jbrowse/plugin-wiggle@2.2.2" has unmet peer dependency "react@>=16.8.0".
warning " > @jbrowse/plugin-wiggle@2.2.2" has unmet peer dependency "tss-react@^3.0.0".
warning "workspace-aggregator-c6d64135-518d-4673-a6aa-7904a097ccdd > @jbrowse/core > @mui/icons-material@5.10.16" has unmet peer dependency "react@^17.0.0 || ^18.0.0".
warning "workspace-aggregator-c6d64135-518d-4673-a6aa-7904a097ccdd > @jbrowse/core > material-ui-popup-state@3.1.1" has unmet peer dependency "react@^15.0.0 || ^16.0.0 || ^17.0.0 || ^18.0.0".
warning "workspace-aggregator-c6d64135-518d-4673-a6aa-7904a097ccdd > @jbrowse/core > react-error-boundary@3.1.4" has unmet peer dependency "react@>=16.13.1".
warning "workspace-aggregator-c6d64135-518d-4673-a6aa-7904a097ccdd > @jbrowse/core > react-use-measure@2.1.1" has unmet peer dependency "react@>=16.13".
warning "workspace-aggregator-c6d64135-518d-4673-a6aa-7904a097ccdd > @jbrowse/core > react-use-measure@2.1.1" has unmet peer dependency "react-dom@>=16.13".
warning "workspace-aggregator-c6d64135-518d-4673-a6aa-7904a097ccdd > @jbrowse/desktop > @mui/x-data-grid@5.17.14" has unmet peer dependency "@mui/system@^5.4.1".
warning "workspace-aggregator-c6d64135-518d-4673-a6aa-7904a097ccdd > @jbrowse/plugin-arc > react-svg-tooltip@0.0.11" has unmet peer dependency "react@^16.3.0".
warning "workspace-aggregator-c6d64135-518d-4673-a6aa-7904a097ccdd > @jbrowse/plugin-arc > react-svg-tooltip@0.0.11" has unmet peer dependency "react-dom@^16.3.0".
warning "workspace-aggregator-c6d64135-518d-4673-a6aa-7904a097ccdd > @jbrowse/plugin-data-management > react-virtualized-auto-sizer@1.0.7" has unmet peer dependency "react@^15.3.0 || ^16.0.0-alpha || ^17.0.0 || ^18.0.0-rc".
warning "workspace-aggregator-c6d64135-518d-4673-a6aa-7904a097ccdd > @jbrowse/plugin-data-management > react-virtualized-auto-sizer@1.0.7" has unmet peer dependency "react-dom@^15.3.0 || ^16.0.0-alpha || ^17.0.0 || ^18.0.0-rc".
warning "workspace-aggregator-c6d64135-518d-4673-a6aa-7904a097ccdd > @jbrowse/plugin-data-management > react-vtree@3.0.0-beta.3" has unmet peer dependency "react@>= 16.8".
warning "workspace-aggregator-c6d64135-518d-4673-a6aa-7904a097ccdd > @jbrowse/plugin-data-management > react-vtree@3.0.0-beta.3" has unmet peer dependency "react-dom@>= 16.8".
warning "workspace-aggregator-c6d64135-518d-4673-a6aa-7904a097ccdd > @jbrowse/plugin-data-management > react-window@1.8.8" has unmet peer dependency "react@^15.0.0 || ^16.0.0 || ^17.0.0 || ^18.0.0".
warning "workspace-aggregator-c6d64135-518d-4673-a6aa-7904a097ccdd > @jbrowse/plugin-data-management > react-window@1.8.8" has unmet peer dependency "react-dom@^15.0.0 || ^16.0.0 || ^17.0.0 || ^18.0.0".
warning "workspace-aggregator-c6d64135-518d-4673-a6aa-7904a097ccdd > @jbrowse/plugin-linear-comparative-view > react-popper@2.3.0" has unmet peer dependency "@popperjs/core@^2.0.0".
warning "workspace-aggregator-c6d64135-518d-4673-a6aa-7904a097ccdd > @jbrowse/plugin-linear-comparative-view > react-popper@2.3.0" has unmet peer dependency "react@^16.8.0 || ^17 || ^18".
warning "workspace-aggregator-c6d64135-518d-4673-a6aa-7904a097ccdd > @jbrowse/plugin-linear-comparative-view > react-popper@2.3.0" has unmet peer dependency "react-dom@^16.8.0 || ^17 || ^18".
warning "workspace-aggregator-c6d64135-518d-4673-a6aa-7904a097ccdd > @jbrowse/plugin-menus > react-dropzone@14.2.3" has unmet peer dependency "react@>= 16.8 || 18.0.0".
warning "workspace-aggregator-c6d64135-518d-4673-a6aa-7904a097ccdd > @jbrowse/plugin-wiggle > react-d3-axis-mod@0.1.8" has unmet peer dependency "react@>=15.0.0".
warning "workspace-aggregator-c6d64135-518d-4673-a6aa-7904a097ccdd > @jbrowse/plugin-wiggle > react-draggable@4.4.5" has unmet peer dependency "react@>= 16.3.0".
warning "workspace-aggregator-c6d64135-518d-4673-a6aa-7904a097ccdd > @jbrowse/plugin-wiggle > react-draggable@4.4.5" has unmet peer dependency "react-dom@>= 16.3.0".

After, 8 warnings

warning "@craco/craco > autoprefixer@10.4.13" has unmet peer dependency "postcss@^8.1.0".
warning " > @mui/x-data-grid@5.17.14" has unmet peer dependency "@mui/system@^5.4.1".
warning " > @storybook/react@6.5.14" has unmet peer dependency "require-from-string@^2.0.2".
warning "eslint-config-react-app > eslint-plugin-flowtype@8.0.3" has unmet peer dependency "@babel/plugin-syntax-flow@^7.14.5".
warning "eslint-config-react-app > eslint-plugin-flowtype@8.0.3" has unmet peer dependency "@babel/plugin-transform-react-jsx@^7.14.9".
warning "workspace-aggregator-f7d4b078-b760-4acb-928c-feb13c6173c9 > @jbrowse/plugin-arc > react-svg-tooltip@0.0.11" has incorrect peer dependency "react@^16.3.0".
warning "workspace-aggregator-f7d4b078-b760-4acb-928c-feb13c6173c9 > @jbrowse/plugin-arc > react-svg-tooltip@0.0.11" has incorrect peer dependency "react-dom@^16.3.0".

most of the errors were fixed by adding these to the root package.json devDependencies. this is appropriate in some circumstances, in others, it is better for it to somehow get converted to a true dependency, but i think we do ok by adding these. the reason we did not have them historically is a little bit related to e.g. the create-react-app roots of the repo, which tries to provide these dependencies like eslint, webpack, etc in a somewhat covert way

We could go a bit further to fix the remaining warnings, or figure out alternative methods.

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Dec 14, 2022
@cmdcolin cmdcolin added internal and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Dec 14, 2022
@cmdcolin cmdcolin force-pushed the reduce_peerdep_warnings branch 2 times, most recently from 40be461 to 87e2eaa Compare December 14, 2022 04:13
@codecov
Copy link

codecov bot commented Dec 14, 2022 •
edited
Loading

Codecov Report

Merging #3400 (5bb1e0d) into main (371db6b) will decrease coverage by 0.00%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##             main    #3400      +/-   ##
==========================================
- Coverage   60.48%   60.47%   -0.01%     
==========================================
  Files         823      823              
  Lines       29807    29806       -1     
  Branches     7176     7181       +5     
==========================================
- Hits        18028    18026       -2     
- Misses      11591    11592       +1     
  Partials      188      188
Impacted Files Coverage Δ
...ome-view/src/LinearGenomeView/components/Ruler.tsx 94.44% <75.00%> (-5.56%) ⬇️
packages/core/ui/PrerenderedCanvas.tsx 90.90% <100.00%> (ø)
...iveDisplay/components/LinearComparativeDisplay.tsx 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cmdcolin cmdcolin merged commit 5568a08 into main Dec 15, 2022
@cmdcolin cmdcolin deleted the reduce_peerdep_warnings branch December 15, 2022 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@cmdcolin