Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce overplotting on dotplot grid lines and other misc improvements #3403

Merged
merged 3 commits into from Dec 15, 2022

Conversation

cmdcolin
Copy link
Collaborator

  • Reduce overplotting of grid lines
  • Improve tick label layout

Fixes #3397

Some screenshots

before
Screenshot from 2022-12-14 22-33-21

after
Screenshot from 2022-12-14 22-34-13

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Dec 15, 2022
@cmdcolin
Copy link
Collaborator Author

on hg38 vs hg19

before

Screenshot from 2022-12-14 22-31-36

after

Screenshot from 2022-12-14 22-31-23

@cmdcolin cmdcolin added enhancement New feature or request and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Dec 15, 2022
@cmdcolin cmdcolin changed the title Dotplot drawing improvements Reduce overplotting on dotplot grid lines and other misc improvements Dec 15, 2022
@codecov
Copy link

codecov bot commented Dec 15, 2022

Codecov Report

Merging #3403 (cef12f3) into main (371db6b) will increase coverage by 0.01%.
The diff coverage is 63.10%.

@@            Coverage Diff             @@
##             main    #3403      +/-   ##
==========================================
+ Coverage   60.48%   60.50%   +0.01%     
==========================================
  Files         823      824       +1     
  Lines       29807    29770      -37     
  Branches     7176     7165      -11     
==========================================
- Hits        18028    18011      -17     
+ Misses      11591    11573      -18     
+ Partials      188      186       -2     
Impacted Files Coverage Δ
plugins/dotplot-view/src/util.ts 40.74% <ø> (-20.28%) ⬇️
...ot-view/src/DotplotView/components/DotplotView.tsx 50.83% <42.00%> (+2.55%) ⬆️
...view/src/DotplotView/components/DotplotTooltip.tsx 42.85% <42.85%> (ø)
...s/dotplot-view/src/DotplotView/components/Axes.tsx 93.33% <96.22%> (+5.64%) ⬆️
...plot-view/src/DotplotReadVsRef/DotplotReadVsRef.ts 93.33% <100.00%> (+21.53%) ⬆️
plugins/dotplot-view/src/DotplotReadVsRef/index.ts 100.00% <100.00%> (ø)
...ns/dotplot-view/src/DotplotView/components/util.ts 86.36% <100.00%> (ø)
plugins/dotplot-view/src/DotplotView/model.ts 60.08% <100.00%> (+1.01%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cmdcolin cmdcolin merged commit 890b199 into main Dec 15, 2022
@cmdcolin cmdcolin deleted the dotplot_drawing branch December 15, 2022 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make dotplot display look less messy with hundreds to thousands of scaffolds
1 participant