Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove trackhub registry plugin from core plugins, moved to plugin store #3407

Merged
merged 1 commit into from
Dec 15, 2022

Conversation

cmdcolin
Copy link
Collaborator

As nice as trackhub registry is, they changed the API format on us so now it does not work

a) now requires application/json content-type which we did not have, so crashes currently with a HTTP 415
b) renamed id->trackhub_id in response JSON which breaks our map in several places

I propose removing it from our corePlugins, and moving to an external (not done yet) where it can be updated as needed

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Dec 15, 2022
@cmdcolin cmdcolin removed the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Dec 15, 2022
@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Dec 15, 2022
@cmdcolin cmdcolin added bug Something isn't working and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Dec 15, 2022
@codecov
Copy link

codecov bot commented Dec 15, 2022

Codecov Report

Merging #3407 (7de7afc) into main (5568a08) will increase coverage by 0.53%.
The diff coverage is n/a.

❗ Current head 7de7afc differs from pull request most recent head c4b74c1. Consider uploading reports for the commit c4b74c1 to get more accurate results

@@            Coverage Diff             @@
##             main    #3407      +/-   ##
==========================================
+ Coverage   60.51%   61.04%   +0.53%     
==========================================
  Files         824      816       -8     
  Lines       29791    29522     -269     
  Branches     7187     7100      -87     
==========================================
- Hits        18027    18023       -4     
+ Misses      11578    11322     -256     
+ Partials      186      177       -9     
Impacted Files Coverage Δ
products/jbrowse-desktop/src/corePlugins.ts 100.00% <ø> (ø)
products/jbrowse-web/src/corePlugins.ts 100.00% <ø> (ø)
products/jbrowse-web/src/util.ts 48.33% <0.00%> (ø)
packages/core/ui/PrerenderedCanvas.tsx 90.90% <0.00%> (ø)
...iveDisplay/components/LinearComparativeDisplay.tsx 100.00% <0.00%> (ø)
...ome-view/src/LinearGenomeView/components/Ruler.tsx 100.00% <0.00%> (+5.55%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cmdcolin cmdcolin changed the title Remove trackhub registry plugin from corePlugins Remove trackhub registry plugin from core plugins, moved to plugin store Dec 15, 2022
@cmdcolin cmdcolin merged commit cd37997 into main Dec 15, 2022
@cmdcolin cmdcolin deleted the remove_trackhub_registry branch December 15, 2022 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant