Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a "base" set of tracks and assemblies for the embedded demos #3413

Merged
merged 4 commits into from
Dec 16, 2022

Conversation

cmdcolin
Copy link
Collaborator

@cmdcolin cmdcolin commented Dec 16, 2022

  • Adds a "base" tracks.ts and assembly.ts that is copied to each embedded demo by a shell script (symlink is not used because i want people to be able to clone this subdirectory and work with it standalone)

  • Renames folder demos->embedded_demos

  • Removes unused test files in embedded demos

  • Gives license:MIT in each demo

  • Updates to nextjs 13 in lgv demo (previously had a bug with their swc minfier and @gmod/binary-parser, helped them to get this fixed)

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Dec 16, 2022
@cmdcolin cmdcolin added enhancement New feature or request and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Dec 16, 2022
@codecov
Copy link

codecov bot commented Dec 16, 2022

Codecov Report

Merging #3413 (20da5a8) into main (7e93ce7) will not change coverage.
The diff coverage is n/a.

❗ Current head 20da5a8 differs from pull request most recent head 1903f4b. Consider uploading reports for the commit 1903f4b to get more accurate results

@@           Coverage Diff           @@
##             main    #3413   +/-   ##
=======================================
  Coverage   61.23%   61.23%           
=======================================
  Files         816      816           
  Lines       29520    29520           
  Branches     7109     7109           
=======================================
  Hits        18077    18077           
  Misses      11270    11270           
  Partials      173      173           
Impacted Files Coverage Δ
products/jbrowse-web/src/util.ts 48.33% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cmdcolin cmdcolin merged commit afba531 into main Dec 16, 2022
@cmdcolin cmdcolin deleted the base_embedded_demos branch December 16, 2022 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant