Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rendering alignment arcs on files that need refname renaming and add jitter setting #3416

Merged
merged 6 commits into from
Dec 17, 2022

Conversation

cmdcolin
Copy link
Collaborator

Fixes #3409

Found that the exome datasets we use are slightly different on web and embedded demos, one needs ref name renaming and one doesn't

https://s3.amazonaws.com/jbrowse.org/genomes/GRCh38/alignments/NA12878/NA12878.alt_bwamem_GRCh38DH.20150826.CEU.exome.cram'
https://s3.amazonaws.com/1000genomes/phase3/data/NA12878/exome_alignment/NA12878.mapped.ILLUMINA.bwa.CEU.exome.20121211.bam

This PR fixes arc rendering/read cloud rendering on files that need refname renaming

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Dec 17, 2022
@cmdcolin cmdcolin changed the title Fix refname renaming arc Fix rendering alignments arcs on tracks that need refname renaming Dec 17, 2022
@cmdcolin cmdcolin added bug Something isn't working and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Dec 17, 2022
@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Dec 17, 2022
@codecov
Copy link

codecov bot commented Dec 17, 2022

Codecov Report

Merging #3416 (c6c7afd) into main (cc6a0eb) will increase coverage by 0.00%.
The diff coverage is 71.79%.

❗ Current head c6c7afd differs from pull request most recent head 4ed7861. Consider uploading reports for the commit 4ed7861 to get more accurate results

@@           Coverage Diff           @@
##             main    #3416   +/-   ##
=======================================
  Coverage   61.23%   61.24%           
=======================================
  Files         816      816           
  Lines       29520    29537   +17     
  Branches     7109     7111    +2     
=======================================
+ Hits        18077    18089   +12     
- Misses      11270    11275    +5     
  Partials      173      173           
Impacted Files Coverage Δ
.../alignments/src/LinearReadArcsDisplay/drawFeats.ts 81.13% <54.54%> (-2.55%) ⬇️
...alignments/src/LinearReadCloudDisplay/drawFeats.ts 86.31% <94.11%> (+0.26%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cmdcolin cmdcolin removed the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Dec 17, 2022
@cmdcolin cmdcolin changed the title Fix rendering alignments arcs on tracks that need refname renaming Fix rendering alignment arcs on files that need refname renaming Dec 17, 2022
@cmdcolin
Copy link
Collaborator Author

adds ability to "jitter" x positions of arcs now also, and has a small jitter on by default. this can help when there are many reads mapping to exactly the same position to show the "magnitude of the arc more"

example

no jitter (current main)
Screenshot from 2022-12-17 15-50-15
small jitter (default now)
Screenshot from 2022-12-17 15-50-02
large
Screenshot from 2022-12-17 15-52-33

@cmdcolin cmdcolin changed the title Fix rendering alignment arcs on files that need refname renaming Fix rendering alignment arcs on files that need refname renaming and add jitter setting Dec 17, 2022
@cmdcolin cmdcolin merged commit 96d062b into main Dec 17, 2022
@cmdcolin cmdcolin deleted the fix_refname_renaming_arc branch December 17, 2022 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Arc view on exome data
1 participant