-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix rendering alignment arcs on files that need refname renaming and add jitter setting #3416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs label triage
Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal)
label
Dec 17, 2022
cmdcolin
changed the title
Fix refname renaming arc
Fix rendering alignments arcs on tracks that need refname renaming
Dec 17, 2022
cmdcolin
added
bug
Something isn't working
and removed
needs label triage
Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal)
labels
Dec 17, 2022
github-actions
bot
added
the
needs label triage
Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal)
label
Dec 17, 2022
Codecov Report
@@ Coverage Diff @@
## main #3416 +/- ##
=======================================
Coverage 61.23% 61.24%
=======================================
Files 816 816
Lines 29520 29537 +17
Branches 7109 7111 +2
=======================================
+ Hits 18077 18089 +12
- Misses 11270 11275 +5
Partials 173 173
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
cmdcolin
removed
the
needs label triage
Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal)
label
Dec 17, 2022
cmdcolin
changed the title
Fix rendering alignments arcs on tracks that need refname renaming
Fix rendering alignment arcs on files that need refname renaming
Dec 17, 2022
cmdcolin
force-pushed
the
fix_refname_renaming_arc
branch
from
December 17, 2022 22:49
65daf55
to
c4e255c
Compare
cmdcolin
force-pushed
the
fix_refname_renaming_arc
branch
from
December 17, 2022 22:52
c4e255c
to
4ed7861
Compare
cmdcolin
changed the title
Fix rendering alignment arcs on files that need refname renaming
Fix rendering alignment arcs on files that need refname renaming and add jitter setting
Dec 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3409
Found that the exome datasets we use are slightly different on web and embedded demos, one needs ref name renaming and one doesn't
https://s3.amazonaws.com/jbrowse.org/genomes/GRCh38/alignments/NA12878/NA12878.alt_bwamem_GRCh38DH.20150826.CEU.exome.cram'
https://s3.amazonaws.com/1000genomes/phase3/data/NA12878/exome_alignment/NA12878.mapped.ILLUMINA.bwa.CEU.exome.20121211.bam
This PR fixes arc rendering/read cloud rendering on files that need refname renaming