Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to revcomp sequence in the "Get sequence" dialog #3421

Merged
merged 1 commit into from
Dec 20, 2022

Conversation

cmdcolin
Copy link
Collaborator

Adds the ability to reverse and complement the sequence in the get sequence dialog (allowing reverse complement if both are checked)

Screenshot from 2022-12-19 20-52-25

@cmdcolin cmdcolin changed the title Add ability to revcomp sequence to the get sequence dialog Add ability to revcomp sequence in the get sequence dialog Dec 20, 2022
@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Dec 20, 2022
@cmdcolin cmdcolin changed the title Add ability to revcomp sequence in the get sequence dialog Add ability to revcomp sequence in the "Get sequence" dialog Dec 20, 2022
@cmdcolin cmdcolin added enhancement New feature or request and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Dec 20, 2022
@codecov
Copy link

codecov bot commented Dec 20, 2022

Codecov Report

Merging #3421 (2f2249f) into main (a4e9f67) will decrease coverage by 0.01%.
The diff coverage is 26.47%.

@@            Coverage Diff             @@
##             main    #3421      +/-   ##
==========================================
- Coverage   61.35%   61.34%   -0.02%     
==========================================
  Files         818      818              
  Lines       29526    29541      +15     
  Branches     7098     7104       +6     
==========================================
+ Hits        18117    18122       +5     
- Misses      11239    11248       +9     
- Partials      170      171       +1     
Impacted Files Coverage Δ
.../LinearGenomeView/components/GetSequenceDialog.tsx 52.87% <26.47%> (-4.08%) ⬇️
products/jbrowse-web/src/util.ts 48.33% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cmdcolin cmdcolin merged commit 557d8b9 into main Dec 20, 2022
@cmdcolin cmdcolin deleted the getseq_revcomp branch December 20, 2022 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant