-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore console mocks after running #3443
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs label triage
Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal)
label
Jan 9, 2023
Codecov Report
@@ Coverage Diff @@
## main #3443 +/- ##
==========================================
+ Coverage 61.38% 61.50% +0.12%
==========================================
Files 822 821 -1
Lines 29516 29448 -68
Branches 7089 7072 -17
==========================================
- Hits 18119 18113 -6
+ Misses 11226 11172 -54
+ Partials 171 163 -8
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
also removes plugins/protein, it is unused, and can be revived if particular function needs adding if needed |
cmdcolin
added
internal
and removed
needs label triage
Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal)
labels
Jan 9, 2023
cmdcolin
force-pushed
the
test_console_fixes
branch
from
January 9, 2023 18:11
d66b1d3
to
5ddfe73
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3425
Typescriptifies some tests and tries to isolate the console mocking to a single test in most cases