Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore console mocks after running #3443

Merged
merged 9 commits into from
Jan 9, 2023
Merged

Restore console mocks after running #3443

merged 9 commits into from
Jan 9, 2023

Conversation

cmdcolin
Copy link
Collaborator

@cmdcolin cmdcolin commented Jan 9, 2023

Fixes #3425

Typescriptifies some tests and tries to isolate the console mocking to a single test in most cases

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Jan 9, 2023
@codecov
Copy link

codecov bot commented Jan 9, 2023

Codecov Report

Merging #3443 (d66b1d3) into main (89ba904) will increase coverage by 0.12%.
The diff coverage is 97.61%.

@@            Coverage Diff             @@
##             main    #3443      +/-   ##
==========================================
+ Coverage   61.38%   61.50%   +0.12%     
==========================================
  Files         822      821       -1     
  Lines       29516    29448      -68     
  Branches     7089     7072      -17     
==========================================
- Hits        18119    18113       -6     
+ Misses      11226    11172      -54     
+ Partials      171      163       -8     
Impacted Files Coverage Δ
packages/core/ui/FatalErrorDialog.tsx 75.00% <ø> (-9.62%) ⬇️
...ns/variants/src/VcfTabixAdapter/VcfTabixAdapter.ts 91.66% <ø> (-0.18%) ⬇️
...ircular-genome-view/src/createModel/createModel.ts 37.50% <ø> (ø)
...-linear-genome-view/src/createModel/createModel.ts 38.46% <ø> (ø)
...ins/data-management/src/PluginStoreWidget/index.ts 80.00% <80.00%> (-20.00%) ⬇️
packages/core/PluginManager.ts 89.35% <100.00%> (-0.77%) ⬇️
...s/data-management/src/AddConnectionWidget/index.ts 100.00% <100.00%> (ø)
...lugins/data-management/src/AddTrackWidget/index.ts 100.00% <100.00%> (ø)
...ement/src/HierarchicalTrackSelectorWidget/index.ts 100.00% <100.00%> (ø)
plugins/data-management/src/index.ts 100.00% <100.00%> (+5.00%) ⬆️
... and 6 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cmdcolin
Copy link
Collaborator Author

cmdcolin commented Jan 9, 2023

also removes plugins/protein, it is unused, and can be revived if particular function needs adding if needed

@cmdcolin cmdcolin added internal and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Jan 9, 2023
@cmdcolin cmdcolin merged commit aa43be2 into main Jan 9, 2023
@cmdcolin cmdcolin deleted the test_console_fixes branch January 9, 2023 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restore jest console mocks to ensure error output is not hidden incorrectly
1 participant