Use notarytool for macOS desktop signing #3452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs label triage
|
I don't believe this is related to the failure seen in https://github.com/GMOD/jbrowse-components/actions/runs/3894314885/jobs/6648130774 but could be worth checking anyways |
cmdcolin
added
enhancement
|
got an email saying this probably needs updating by about ~november
|
Codecov Report
@@ Coverage Diff @@
## main #3452 +/- ##
=======================================
Coverage 64.10% 64.10%
=======================================
Files 987 987
Lines 29668 29668
Branches 7097 7097
=======================================
Hits 19018 19018
Misses 10486 10486
Partials 164 164 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches from 'legacy' (default) in @electron/notarize to 'notarytool' because the legacy says it'll be deprecated late 2023
Also suggests that the newer 'notarytool' is up to 10x faster https://github.com/electron/notarize
possibly will need to add 'teamId' also? see the readme https://github.com/electron/notarize (
teamId String - The team ID you want to notarize under., which is not in the legacy one)