Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Larger margins to add track workflow to visually clarify next button behavior #3477

Merged
merged 2 commits into from
Jan 27, 2023
Merged

Larger margins to add track workflow to visually clarify next button behavior #3477

merged 2 commits into from
Jan 27, 2023

Conversation

cmdcolin
Copy link
Collaborator

Screenshots

before
Screenshot from 2023-01-25 13-34-54

after
Screenshot from 2023-01-25 13-34-46

@cmdcolin
Larger margin between file selectors and next button, to try to clari…
3ca1ce2 
…fy that the next is distinctly not e.g. attached to the second file selector
@cmdcolin
Works without vertical flex
e850b4a
@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Jan 25, 2023
@cmdcolin
Copy link
Collaborator Author

this PR is a follow up from our weekly today which was discussing users potentially being confused by our 'add track widget' UI

there could be a larger discussion about how to simplify or clarify it but this was a simple remedy to try to distinguish the next button vertically a bit with the larger margin

@codecov
Copy link

codecov bot commented Jan 25, 2023 •
edited
Loading

Codecov Report

Merging #3477 (e850b4a) into main (f616117) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #3477   +/-   ##
=======================================
  Coverage   61.43%   61.43%           
=======================================
  Files         820      820           
  Lines       29479    29479           
  Branches     7054     7054           
=======================================
  Hits        18109    18109           
  Misses      11209    11209           
  Partials      161      161
Impacted Files Coverage Δ
...TrackWidget/components/DefaultAddTrackWorkflow.tsx 66.66% <ø> (ø)
...rc/AddTrackWidget/components/TrackSourceSelect.tsx 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cmdcolin cmdcolin added enhancement New feature or request and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Jan 25, 2023
@cmdcolin cmdcolin changed the title Larger margins to add track workflow to clarify that the next buttons behavior Larger margins to add track workflow to visually clarify next button behavior Jan 25, 2023
@cmdcolin cmdcolin merged commit 8e664f3 into main Jan 27, 2023
@cmdcolin cmdcolin deleted the larger_next_margin branch January 27, 2023 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@cmdcolin