Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix loading external plugins in embedded linear-genome-view demo #3482

Merged
merged 3 commits into from
Jan 27, 2023

Conversation

cmdcolin
Copy link
Collaborator

Since version v2.1.6 https://jbrowse.org/jb2/blog/2022/10/19/v2.1.6-release/ the 'loading external plugins in embedded lgv' demo has been broken. This is due to changes in the PluginLoader to support loading relative paths (relative to a window.location.href or baseUrl) in jbrowse-web

This came from a confusion in my case that new URL(someUrl,baseUrl='') would just ignore the baseUrl, but it actually throws an exception when baseUrl is an empty string. This updates the code to use undefined instead of empty string, and then wires the code so undefineds flow through the pluginLoader instead of empty string

@cmdcolin cmdcolin changed the title Fix loading external plugins in embedded linear-genome-view Fix loading external plugins in embedded linear-genome-view demo Jan 26, 2023
@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Jan 26, 2023
@cmdcolin cmdcolin removed the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Jan 26, 2023
@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Jan 26, 2023
@cmdcolin cmdcolin force-pushed the fix_base_url_for_pluginloader_embedded branch from 6c94962 to 212402d Compare January 26, 2023 22:34
@cmdcolin cmdcolin added bug Something isn't working and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Jan 26, 2023
@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Jan 26, 2023
@codecov
Copy link

codecov bot commented Jan 26, 2023

Codecov Report

Merging #3482 (ab3e757) into main (b3f0651) will not change coverage.
The diff coverage is 33.33%.

❗ Current head ab3e757 differs from pull request most recent head 7a85bf2. Consider uploading reports for the commit 7a85bf2 to get more accurate results

@@           Coverage Diff           @@
##             main    #3482   +/-   ##
=======================================
  Coverage   61.41%   61.41%           
=======================================
  Files         820      820           
  Lines       29498    29498           
  Branches     7056     7055    -1     
=======================================
  Hits        18115    18115           
  Misses      11222    11222           
  Partials      161      161           
Impacted Files Coverage Δ
...owse-react-circular-genome-view/src/loadPlugins.ts 0.00% <0.00%> (ø)
...browse-react-linear-genome-view/src/loadPlugins.ts 0.00% <0.00%> (ø)
packages/core/PluginLoader.ts 49.42% <50.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cmdcolin cmdcolin removed the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Jan 26, 2023
@cmdcolin cmdcolin force-pushed the fix_base_url_for_pluginloader_embedded branch 2 times, most recently from ab3e757 to ded28e8 Compare January 27, 2023 06:31
@cmdcolin cmdcolin force-pushed the fix_base_url_for_pluginloader_embedded branch from ded28e8 to 25bfee8 Compare January 27, 2023 06:43
@cmdcolin cmdcolin merged commit fc286e0 into main Jan 27, 2023
@cmdcolin cmdcolin deleted the fix_base_url_for_pluginloader_embedded branch January 27, 2023 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant