Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storybook 7 #3487

Merged
merged 8 commits into from
Jan 27, 2023
Merged

Storybook 7 #3487

merged 8 commits into from
Jan 27, 2023

Conversation

cmdcolin
Copy link
Collaborator

Storybook is going to come out with v7, this updates it to the v7 beta

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Jan 27, 2023
@cmdcolin cmdcolin added documentation and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Jan 27, 2023
@cmdcolin
Copy link
Collaborator Author

@cmdcolin
Copy link
Collaborator Author

requires changing our minimum node js version to 14->16 for installing devDeps

@cmdcolin
Copy link
Collaborator Author

also updates our next.js page in the lgv storybook, much of what is described in it is unnecessary now and so it just links to our latest embedded_demos page

@codecov
Copy link

codecov bot commented Jan 27, 2023

Codecov Report

Merging #3487 (ffba6e2) into main (69f4eb5) will not change coverage.
The diff coverage is n/a.

❗ Current head ffba6e2 differs from pull request most recent head 54ae553. Consider uploading reports for the commit 54ae553 to get more accurate results

@@           Coverage Diff           @@
##             main    #3487   +/-   ##
=======================================
  Coverage   61.13%   61.13%           
=======================================
  Files         832      832           
  Lines       29659    29659           
  Branches     7076     7076           
=======================================
  Hits        18132    18132           
  Misses      11365    11365           
  Partials      162      162           
Impacted Files Coverage Δ
products/jbrowse-web/src/util.ts 48.33% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cmdcolin
Copy link
Collaborator Author

maybe can merge for now

@cmdcolin cmdcolin merged commit f6794d5 into main Jan 27, 2023
@cmdcolin cmdcolin deleted the storybook7 branch January 27, 2023 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant