Use transitionDuration 0 as defaultProp in theme for both popovers and menus #3494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs label triage
cmdcolin
added
enhancement
Codecov Report
@@ Coverage Diff @@
## main #3494 +/- ##
=======================================
Coverage 61.09% 61.09%
=======================================
Files 833 833
Lines 29698 29698
Branches 7088 7088
=======================================
Hits 18144 18144
Misses 11392 11392
Partials 162 162
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
I also tried out adjusting global "transition duration" theme hooks from https://codesandbox.io/s/hungry-tree-4eixn2?file=/index.tsx from https://mui.com/material-ui/customization/transitions/ but it didn't seem to affect timing afaict |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, there is a single transitionDuration 0 on the @jbrowse/core/ui/Menu component which makes it popup fast without animation. This PR goes a bit further and applies it to all popovers and menus via defaultProps in the theme. I noticed this because the CascadingMenu (a special type of menu only used on trackMenus right now) had the slowish animation, so I made it faster here.