Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme adjustments #3522

Merged
merged 4 commits into from
Feb 16, 2023
Merged

Theme adjustments #3522

merged 4 commits into from
Feb 16, 2023

Conversation

cmdcolin
Copy link
Collaborator

@cmdcolin cmdcolin commented Feb 16, 2023

fixes an issue with config file themes, and makes <Link> color forest green like it is on previously released versions

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Feb 16, 2023
@cmdcolin cmdcolin removed the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Feb 16, 2023
@cmdcolin
Copy link
Collaborator Author

I tried also restoring some "color=secondary" to some iconbuttons by trying to make a custom new custom color (similar to how we have color=quaternary, color=tertiary). it looks a little odd in some places to make all icons secondary, but tagging a couple icons as color=customcolor was not bad, but the typescript doesn't like it even if you update the modular augmentation in theme.ts appropriately AFAIK

@cmdcolin cmdcolin merged commit 819526f into main Feb 16, 2023
@cmdcolin cmdcolin deleted the theme_adjustments branch February 16, 2023 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant