Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breakpoint split view SVG export #3527

Merged
merged 5 commits into from
Feb 19, 2023
Merged

Breakpoint split view SVG export #3527

merged 5 commits into from
Feb 19, 2023

Conversation

cmdcolin
Copy link
Collaborator

Fixes #2269

This rounds out the SVG exporting of all our normal view types, except the tabular view, not sure that is a good candidate anyhow though

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Feb 19, 2023
@cmdcolin
Copy link
Collaborator Author

whitespace-ignored diff is a bit easier to read https://github.com/GMOD/jbrowse-components/compare/svg_breakpoint_split_view?expand=1&w=1

@codecov
Copy link

codecov bot commented Feb 19, 2023

Codecov Report

Merging #3527 (6e5947a) into main (363f1ce) will increase coverage by 0.06%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##             main    #3527      +/-   ##
==========================================
+ Coverage   62.58%   62.64%   +0.06%     
==========================================
  Files         862      865       +3     
  Lines       30164    30258      +94     
  Branches     7234     7261      +27     
==========================================
+ Hits        18878    18956      +78     
- Misses      11098    11111      +13     
- Partials      188      191       +3     
Impacted Files Coverage Δ
.../BreakpointSplitView/components/Translocations.tsx 3.50% <0.00%> (ø)
...s/linear-genome-view/src/LinearGenomeView/model.ts 84.71% <ø> (ø)
...BreakpointSplitView/components/ExportSvgDialog.tsx 66.66% <66.66%> (ø)
...pointSplitView/components/AlignmentConnections.tsx 80.28% <72.72%> (+1.11%) ⬆️
...iew/src/BreakpointSplitView/components/Overlay.tsx 80.00% <80.00%> (ø)
...aseLinearDisplay/models/BaseLinearDisplayModel.tsx 86.89% <80.00%> (ø)
...SplitView/svgcomponents/SVGBreakpointSplitView.tsx 93.33% <93.33%> (ø)
...w/src/BreakpointSplitView/components/Breakends.tsx 84.74% <100.00%> (ø)
...kpointSplitView/components/BreakpointSplitView.tsx 100.00% <100.00%> (+7.14%) ⬆️
...kpoint-split-view/src/BreakpointSplitView/model.ts 77.89% <100.00%> (+1.75%) ⬆️
... and 5 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cmdcolin
Copy link
Collaborator Author

note that this requires the blocks to be rendered before exporting svg, so it uses an arbitrary timeout in the test to achieve this. other svg exports properly queue up tasks and don't need this, and additional work on this branch could fix that, but it would require a somewhat larger refactor

@cmdcolin cmdcolin added enhancement New feature or request and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Feb 19, 2023
@cmdcolin cmdcolin merged commit 7c6b97c into main Feb 19, 2023
@cmdcolin cmdcolin deleted the svg_breakpoint_split_view branch February 19, 2023 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Output .svg of SV inspector
1 participant