Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scroll zoom, d-pad, and more click+drag options to dotplot #3561

Merged
merged 6 commits into from
Mar 4, 2023

Conversation

cmdcolin
Copy link
Collaborator

@cmdcolin cmdcolin commented Mar 3, 2023

  1. Adds d-pad pan buttons
  2. Makes wheel scroll perform a zoom instead of a pan (user can change if they want, but wheel scroll to zoom is a more common UI interaction: think google map)
  3. Reduces the action of wheel scroll by dividing by a reduction factor, this makes movements less dramatic
  4. Adds holding ctrl+click-and-drag to pan view. Can also switch around so pan view is the default click-and-drag, and holding control performs region select. The latter is almost more user intuitive, but it reduces discoverability of "Open in linear synteny view" and the precise zooms, so the default is still click-and-drag to select region
  5. Stricter zoom and scroll boundaries for the dotplot, to avoid scrolling out of view

Fixes #3554

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Mar 3, 2023
@cmdcolin
Copy link
Collaborator Author

cmdcolin commented Mar 3, 2023

Example screenshot showing the toggling mode for click and drag mode select

Screenshot from 2023-03-03 13-56-45

@codecov
Copy link

codecov bot commented Mar 3, 2023

Codecov Report

Merging #3561 (fea9adc) into main (c1beaf1) will decrease coverage by 0.02%.
The diff coverage is 57.60%.

@@            Coverage Diff             @@
##             main    #3561      +/-   ##
==========================================
- Coverage   62.61%   62.60%   -0.02%     
==========================================
  Files         864      866       +2     
  Lines       30269    30311      +42     
  Branches     7260     7273      +13     
==========================================
+ Hits        18953    18976      +23     
- Misses      11126    11145      +19     
  Partials      190      190              
Impacted Files Coverage Δ
...-view/src/DotplotView/components/WarningDialog.tsx 0.00% <0.00%> (ø)
products/jbrowse-desktop/src/Loader.tsx 0.00% <0.00%> (ø)
...dotplot-view/src/DotplotView/components/Header.tsx 37.50% <42.85%> (-10.00%) ⬇️
...ot-view/src/DotplotView/components/DotplotView.tsx 51.93% <47.61%> (+1.10%) ⬆️
...iew/src/DotplotView/components/DotplotWarnings.tsx 50.00% <50.00%> (ø)
...lot-view/src/DotplotView/components/PanButtons.tsx 50.00% <50.00%> (ø)
plugins/dotplot-view/src/DotplotView/model.ts 60.40% <71.42%> (+0.65%) ⬆️
packages/core/util/Base1DViewModel.ts 90.00% <85.71%> (+0.25%) ⬆️
plugins/dotplot-view/src/DotplotView/1dview.ts 82.14% <100.00%> (-4.23%) ⬇️
...s/linear-genome-view/src/LinearGenomeView/index.ts 100.00% <100.00%> (ø)
... and 4 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cmdcolin cmdcolin added enhancement New feature or request and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Mar 3, 2023
@cmdcolin cmdcolin merged commit ffe454c into main Mar 4, 2023
@cmdcolin cmdcolin deleted the dotplot_panbuttons branch March 4, 2023 00:14
@cmdcolin cmdcolin changed the title Dotplot UI improvements Add scroll zoom, d-pad, and more click+drag options to dotplot Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add panning buttons to dotplot
1 participant