Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix use of "show all regions with data" feature in SV inspector with TRA entries (with CHR2 from INFO) #3566

Merged
merged 3 commits into from
Mar 7, 2023

Conversation

cmdcolin
Copy link
Collaborator

@cmdcolin cmdcolin commented Mar 7, 2023

Changes featuresRefNamesP (which asynchronously initializes a FromConfigAdapter) to a simpler function that looks at the set of feature refNames and combines it with feature.INFO?.CHR2.

also fixes a couple other small things including

  • moving a jexl addFunction to plugin installation
  • add javadoc style contents

this bug was I think noted by a user at PAG2023

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label Mar 7, 2023
@codecov
Copy link

codecov bot commented Mar 7, 2023

Codecov Report

Merging #3566 (70d0672) into main (d9e5ecc) will increase coverage by 0.02%.
The diff coverage is 82.50%.

@@            Coverage Diff             @@
##             main    #3566      +/-   ##
==========================================
+ Coverage   62.65%   62.67%   +0.02%     
==========================================
  Files         866      866              
  Lines       30285    30275      -10     
  Branches     7290     7289       -1     
==========================================
  Hits        18975    18975              
+ Misses      11119    11111       -8     
+ Partials      191      189       -2     
Impacted Files Coverage Δ
...ctorView/models/breakpointSplitViewFromTableRow.js 11.11% <37.50%> (ø)
...ctor/src/SvInspectorView/models/SvInspectorView.ts 70.79% <90.00%> (-1.21%) ⬇️
plugins/sv-inspector/src/SvInspectorView/index.ts 100.00% <100.00%> (ø)
products/jbrowse-web/src/util.ts 48.33% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cmdcolin cmdcolin added bug Something isn't working and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels Mar 7, 2023
@cmdcolin cmdcolin merged commit 1c35f96 into main Mar 7, 2023
@cmdcolin cmdcolin changed the title Fix use of "show all regions with data" feature in SV inspector with TRA entries (fetch CHR2 from INFO) Fix use of "show all regions with data" feature in SV inspector with TRA entries (with CHR2 from INFO) Mar 7, 2023
@cmdcolin cmdcolin deleted the fix_chr2 branch March 7, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant