Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miscellaneous alignments arc/cloud fixes #3706

Merged
merged 7 commits into from May 16, 2023
Merged

Miscellaneous alignments arc/cloud fixes #3706

merged 7 commits into from May 16, 2023

Conversation

cmdcolin
Copy link
Collaborator

  • Stops coloring mate-missing features TLEN=0 as small arcs/pink boxes
  • Add stroke outline to read cloud rectangle boxes
  • Compact-ify read cloud display (remove some vertical y-axis space)
  • Draw 'singletons' in read cloud display (paired feature not in view, on arc view this is e.g. a vertical line)

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label May 16, 2023
@cmdcolin cmdcolin added enhancement New feature or request and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels May 16, 2023
@codecov
Copy link

codecov bot commented May 16, 2023

Codecov Report

Merging #3706 (0d93f44) into main (70eb9c7) will decrease coverage by 0.01%.
The diff coverage is 76.69%.

@@            Coverage Diff             @@
##             main    #3706      +/-   ##
==========================================
- Coverage   64.21%   64.21%   -0.01%     
==========================================
  Files         924      926       +2     
  Lines       29918    29947      +29     
  Branches     7252     7260       +8     
==========================================
+ Hits        19211    19229      +18     
- Misses      10526    10537      +11     
  Partials      181      181              
Impacted Files Coverage Δ
...lugins/alignments/src/LinearPileupDisplay/model.ts 71.96% <ø> (ø)
...inearReadArcsDisplay/components/ReactComponent.tsx 100.00% <ø> (ø)
...nearReadCloudDisplay/components/ReactComponent.tsx 100.00% <ø> (ø)
...ns/alignments/src/LinearReadCloudDisplay/model.tsx 56.52% <0.00%> (-3.95%) ⬇️
...e/src/MultiDensityRenderer/MultiDensityRenderer.ts 0.00% <ø> (ø)
.../wiggle/src/MultiLineRenderer/MultiLineRenderer.ts 0.00% <ø> (ø)
...e/src/MultiRowLineRenderer/MultiRowLineRenderer.ts 0.00% <ø> (ø)
...c/MultiRowXYPlotRenderer/MultiRowXYPlotRenderer.ts 95.83% <ø> (ø)
...gle/src/MultiXYPlotRenderer/MultiXYPlotRenderer.ts 0.00% <ø> (ø)
plugins/wiggle/src/util.ts 70.53% <ø> (-1.50%) ⬇️
... and 8 more

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cmdcolin cmdcolin merged commit 51fb758 into main May 16, 2023
11 of 12 checks passed
@cmdcolin cmdcolin deleted the arc_fixes branch May 16, 2023 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant