Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved read cloud display for long reads with inversions #3707

Merged
merged 4 commits into from May 17, 2023

Conversation

cmdcolin
Copy link
Collaborator

This improves the 'read cloud' display for long read alignments by chaining alignments all the way through inversions

image

The plot's strand is chosen relative to the 'primary' alignment, so even if reads are on e.g. the negative strand, they are all shown the same direction as reads on the positive strand. Just for reference, here is how it looks when you don't use that adjustment

image

@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label May 17, 2023
@cmdcolin cmdcolin added enhancement New feature or request and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels May 17, 2023
@cmdcolin
Copy link
Collaborator Author

possible enhancements:

  • show this same type of rendering with a 'standard' granular rect layout
  • render mismatches/cigar ins/dels on these glyphs

@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@51fb758). Click here to learn what that means.
The diff coverage is 68.00%.

@@           Coverage Diff           @@
##             main    #3707   +/-   ##
=======================================
  Coverage        ?   64.29%           
=======================================
  Files           ?      931           
  Lines           ?    29960           
  Branches        ?     7251           
=======================================
  Hits            ?    19263           
  Misses          ?    10532           
  Partials        ?      165           
Impacted Files Coverage Δ
...lollipop/src/LollipopRenderer/components/Stick.tsx 100.00% <ø> (ø)
.../alignments/src/LinearReadArcsDisplay/drawFeats.ts 75.92% <25.00%> (ø)
...ns/alignments/src/PileupRenderer/PileupRenderer.ts 62.52% <31.25%> (ø)
...lipop/src/LollipopRenderer/components/Lollipop.tsx 50.00% <50.00%> (ø)
.../LollipopRenderer/components/LollipopRendering.tsx 65.90% <65.90%> (ø)
...ments/src/LinearReadCloudDisplay/drawPairChains.ts 71.42% <71.42%> (ø)
plugins/alignments/src/shared/color.ts 95.45% <91.66%> (ø)
...alignments/src/LinearReadCloudDisplay/drawFeats.ts 86.66% <100.00%> (ø)
...s/src/LinearReadCloudDisplay/drawLongReadChains.ts 100.00% <100.00%> (ø)
plugins/alignments/src/shared/util.ts 100.00% <100.00%> (ø)
... and 2 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@cmdcolin cmdcolin merged commit b862924 into main May 17, 2023
12 checks passed
@cmdcolin cmdcolin deleted the improved_read_cloud branch May 17, 2023 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant