Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add removable-media to jbrowse desktop snap #3708

Merged
merged 1 commit into from May 18, 2023
Merged

Conversation

cmdcolin
Copy link
Collaborator

May help with #3683

I am unable to build the electron-builder binaries locally (could be a separate issue, it is just confusing for my build environment) so difficult to test this

@cmdcolin cmdcolin changed the title Add removable-media to snap Add removable-media to jbrowse desktop snap May 17, 2023
@github-actions github-actions bot added the needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) label May 17, 2023
@cmdcolin cmdcolin added bug Something isn't working and removed needs label triage Needs a label to show in changelog (breaking, enhancement, bug, documentation, or internal) labels May 17, 2023
@cmdcolin
Copy link
Collaborator Author

cmdcolin commented May 18, 2023

the snap usage is probably a very small proportion of users so can maybe just give this a try

@cmdcolin cmdcolin merged commit 9a552d5 into main May 18, 2023
10 checks passed
@cmdcolin cmdcolin deleted the snap_removable_media branch May 18, 2023 17:34
@vvmorita
Copy link

Thank you so much for your attempt. However, I encountered another issue while trying to build the snap (v2.6.1). I received the following error messages:
error: cannot read snap file: cannot have plug and slot with the same name:
"removable-media"
Perhaps it would be better to revert back to the previous version (v2.5.0).

@cmdcolin
Copy link
Collaborator Author

@vvmorita thanks for letting me know. I now just for the first time even tested trying to install the snap locally with e.g. sudo snap install --dangerous jbrowse-desktop-v2.5.0-linux.snap on ubuntu and v2.5.0 does indeed work but v2.6.1 has the error. I can try one more thing with the removable-media thing in next release

@cmdcolin
Copy link
Collaborator Author

@vvmorita new version v2.6.2 released with the bug somewhat reverted. not sure if it helped, but can be installed now at least!

@vvmorita
Copy link

vvmorita commented Jul 14, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants