Silence console warn in CopyAndDelete test #3709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs label triage
cmdcolin
added
internal
and removed
needs label triage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the CopyAndDelete gives a warning that the 'configuration' object is stale. This warning was introduced by splitting TrackContainer into TrackContainer and TrackRenderingContainer
I think this refactor is valid, but unfortunately causes the warning. I propose to silence the warning during test. Many stale warnings are hard to properly fix. The alternative to silencing it is to use getConf in both TrackContainer and TrackRenderingContainer, which appears to make it not go stale. Not sure why that is, but rather than implement this odd workaround, this silences the warning