Add JBrowse R shiny app demo #3732
Conversation
|
github-actions
bot
added
the
needs label triage
carolinebridge
added
documentation
and removed
needs label triage
Codecov Report
@@ Coverage Diff @@
## main #3732 +/- ##
==========================================
- Coverage 64.39% 64.39% -0.01%
==========================================
Files 976 976
Lines 29592 29592
Branches 7094 7094
==========================================
- Hits 19057 19055 -2
- Misses 10370 10372 +2
Partials 165 165 see 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
are you able to deploy it to shinyapps.io to see it live? maybe in your personal account? |
not sure what version is deployed but the look and feel of the JBrowseR component "should" look the same, font size wise and such, as e.g. the @jbrowse/react-linear-genome-view e.g. in the storybook. the embedded components try to 'block out' external page styling that could affect font sizes, etc. possibly we need JBrowseR to get the updated @jbrowse/react-linear-genome-view if for some reason it is old enough that it doesn't have this |
https://cbridge.shinyapps.io/jbrowse-r-shiny/
I think it's v2.0.1? |
|
gotcha. the "avoidParentStyle" class with the css selector all>initial is supposed to avoid font from the outer page bleeding into the inner page but something about the shiny page is bleeding through anyways
|
|
may be due to this particular entry in bootstrap css html {
font-size: 10px;
}
The "initial" may refer to values in "html". you can reproduce similar effect in the embedded-demos and adding e.g. a |
|
note that the latest version of bootstrap may not add this 10px html style...putting e.g. |
|
using a bootstrap theme fixes it! thanks colin |
|
to be clear, i think the page already had some sort of bootstrap.min.css being loaded that added that weird 10px, but might be that the way you adjusted the page it fixed it. it is difficult to debug the issue anyways so this might be a good workaround |
|
here is a small way to reproduce the 'issue' without any bootstrap https://github.com/GMOD/jbrowse-components/compare/bad_style_html_bleed?expand=1&w=1 the all:initial may refer to the "html" section of css instead of some truly "initial" value, but i think you found a reasonable workaround |
|
looks good with the bootstrap addition you made :) 👍 |
…removes toggle shown tracks
|
what do you think about putting the code in embedded_demos? it may not be strictly the same as our other embedded demos but it may work out ok, and avoids a new top level folder |
|
the other alternative is only keeping this code in the jbrowseR repo, but i am open to putting more jbrowseR stuff here. potentially the entire JBrowseR repo could even be moved into this monorepo...a multi-language monorepo. there are likely pros and cons to that |
|
moved to existing folder and new functionality live on https://cbridge.shinyapps.io/jbrowse-r-shiny/ |
|
@carolinebridge-oicr can you run yarn format and fix spelling here https://github.com/GMOD/jbrowse-components/actions/runs/5180240247/jobs/9334165481?pr=3732#step:3:40 |
|
may also need to merge main branch to fix https://github.com/GMOD/jbrowse-components/actions/runs/5180240032/jobs/9334164952?pr=3732#step:8:178 i think that was fixed on main |
|
will probably want to create a workflow to update this demo when we release a new version of jbrowseR. might also move it to gmod.shinyapps.io (I just registered this account), but overall, looks great! |
Adding a JBrowse R demo to our repertoire of live demos.
To be hosted on shinyapps.io.